Bug 375532

Summary:	Desktop color settings are not persisted properly
Product:	[Plasma] plasmashell	Reporter:	slartibart70
Component:	general	Assignee:	David Edmundson <kde>
Status:	RESOLVED FIXED
Severity:	normal	CC:	bhush94, exl, plasma-bugs
Priority:	NOR
Version:	5.8.5
Target Milestone:	1.0
Platform:	Fedora RPMs
OS:	Linux
Latest Commit:	https://commits.kde.org/plasma-workspace/a9f5ada73bf86a145e057eff188f45dfdf61917a	Version Fixed In:
Sentry Crash Report:

Description slartibart70 2017-01-25 08:45:09 UTC

This bug exists since the beginning of plasma5...

Default settings for the desktop on a second monitor is a background picture. I want to replace it with a plain color background.
Steps:
- configure desktop (right click)
- wallpaper - change to 'plain color' type
- click on the color button/selector
- choose whatever color you please
- click apply or OK

Everything seems working until you logout an login again.
Then the setting of the plain color is kept, but the color choice got lost. It's replaced with a bright blueish background color.
After reapplying the color i want, then it will be persisted properly

Maybe now's the time to fix this... :-)

Comment 1 David Edmundson 2017-01-26 16:17:58 UTC

Git commit a9f5ada73bf86a145e057eff188f45dfdf61917a by David Edmundson.
Committed on 26/01/2017 at 16:17.
Pushed by davidedmundson into branch 'Plasma/5.9'.

When swapping Wallpapers, save the config to file, not just to propertymap

Summary:
ContainmentConfigView has a special code path for wallpaper configs
where, if you change wallpaper type, it will create a temporary config
ConfigPropertyMap, then copy it over to the real config when the
containment actually changes.

ConfigPropertyMap does not call valueChanged() on insertion (See
QQmlPropertyMap), and we only write the value into the actual
KConfigSkeleton on valueChange.

Test Plan:
Start plasma with image wallpaper
Set to colour wallpaper and save colour
Hit apply

Close plasma
Start plasma

Before the correct colour wouldn't be loaded. Now it is.

Reviewers: #plasma, mart

Reviewed By: mart

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D4285

M  +3    -1    shell/containmentconfigview.cpp

https://commits.kde.org/plasma-workspace/a9f5ada73bf86a145e057eff188f45dfdf61917a

Comment 2 Christoph Feck 2017-01-27 01:50:02 UTC

*** Bug 367546 has been marked as a duplicate of this bug. ***