Bug 375501

Summary:	Selection color should become lighter if folder view loses focus
Product:	[Plasma] plasmashell	Reporter:	Elvis Angelaccio <elvis.angelaccio>
Component:	Desktop icons & Folder View widget	Assignee:	Eike Hein <hein>
Status:	RESOLVED FIXED
Severity:	wishlist	CC:	kde, nate, plasma-bugs-null
Priority:	NOR	Keywords:	usability
Version First Reported In:	5.8.95
Target Milestone:	1.0
Platform:	Other
OS:	Linux
Latest Commit:	https://commits.kde.org/plasma-desktop/596f979d45c5f1b61042d8278efdaef364c6bdc6	Version Fixed/Implemented In:	5.18.0
Sentry Crash Report:

Description Elvis Angelaccio 2017-01-24 14:22:29 UTC

The selection color (when a file or icon is selected from the FV) does not react to lost of focus, at least with Breeze. This can result in annoying issues, for example:

1. Select a file A in FV
2. Open a Dolphin window
3. Select a file B in Dolphin
4. ...go away for some minutes
5. Hit Del key with the intention of trashing file A (which is selected as if FV had focus)
6. File B gets trashed instead, because Dolphin has focus

Dolphin uses a slightly lighter color for the selected icon(s), when the Dolphin view loses focus. FV should do the same imho.

Comment 1 Kai Uwe Broulik 2017-02-01 16:07:29 UTC

Agreed. This could be easily achieved using:

import QtQuick.Window 2.2

FrameSvgItem {
    opacity: Window.active ? 1 : 0.4
    Behavior on opacity {
        ...
    }
}

Comment 2 Nate Graham 2019-11-05 19:31:19 UTC

Patch: https://phabricator.kde.org/D25160

Comment 3 Nate Graham 2019-11-05 20:14:32 UTC

Git commit 596f979d45c5f1b61042d8278efdaef364c6bdc6 by Nate Graham.
Committed on 05/11/2019 at 20:14.
Pushed by ngraham into branch 'master'.

[Folder View] Use an inactive highlight effect when something else has focus

Summary:
The theme SVG doesn't have a concept of "inactive selection highlight", so we need to
manufacture our own by reducing the opacity of the selection highlight.

Thanks to @broulik for suggesting the necessary code changes in the bug report.
FIXED-IN: 5.18.0

Test Plan: {F7743147}

Reviewers: #plasma, #vdg, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: broulik, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D25160

M  +4    -0    containments/desktop/package/contents/ui/FolderItemDelegate.qml

https://commits.kde.org/plasma-desktop/596f979d45c5f1b61042d8278efdaef364c6bdc6