Bug 375408

Summary:	Don't change context menu shortcut keys in single vs. multiple image context menus
Product:	[Applications] digikam	Reporter:	Dan Dascalescu <ddascalescu+kde>
Component:	Usability-Keyboard	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	caulier.gilles, laurakittyinka
Priority:	NOR
Version:	5.5.0
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://commits.kde.org/digikam/be046aaa7769385c5c684af9aa8edc730410ddce	Version Fixed In:	5.5.0
Sentry Crash Report:
Attachments:	One image -> "i" Two images -> "s"

Description Dan Dascalescu 2017-01-22 14:47:23 UTC

Goal: tag images fast, using the keyboard

Workflow: "right click" (I actually use the keyboard combination that brings up the context menu, Fn+Print Screen) an image or select multiple images bring up the context menu, then continue using the keyboard to navigate in the menu and tag.

The problem is that if one image is selected, the shortcut for "Assign Tag" is "i". If multiple images are selected, the shortcut is "s".

Can we have the same shortcut, to help form muscle memory?

Comment 1 caulier.gilles 2017-01-22 14:54:05 UTC

Not reproducible here with AppImage 5.5.0. In both cases, 'A' is always the shortcut from context menu for this action.

Desktop : plasma5

Comment 2 Barbara Scheffner 2017-01-22 15:31:18 UTC

In Configure Shortcuts... I found Assign Tag with T as shortcut which is wrong. T is More Tags... and opens the Tags tree in the Captions tab of the Right Sidebar. Icon is also wrong, it is the one for Add Tag. All this is default. Should be corrected IMHO since one cannot even correct it by himself in Configure Shortcuts...

Comment 3 Dan Dascalescu 2017-01-22 18:30:49 UTC

Created attachment 103589 [details]
One image -> "i"

Comment 4 Dan Dascalescu 2017-01-22 18:32:54 UTC

Created attachment 103590 [details]
Two images -> "s"

KDE probably assigns shortcuts automatically, and when only one image is selected, there's an additional menu entry, "Set as Album Thumbnail", which takes "S", so "Assign" gets the next available letter, "i". ("A" is taken by "Add to Light Table").

Comment 5 Simon 2017-01-22 19:45:17 UTC

It is QT who does this automatically (unless specified, but I think we
don't do that). The difference between your screenshot and my context
menu is, that there is an entry called "Place onto Light Table" and in
yours it is "Add to Light Table", which takes up "A" in your case. What
kind of digikam install do you use?

On 22/01/17 19:32, Dan Dascalescu wrote:
> https://bugs.kde.org/show_bug.cgi?id=375408
>
> --- Comment #4 from Dan Dascalescu <ddascalescu+kde@gmail.com> ---
> Created attachment 103590 [details]
>   --> https://bugs.kde.org/attachment.cgi?id=103590&action=edit
> Two images -> "s"
>
> KDE probably assigns shortcuts automatically, and when only one image is
> selected, there's an additional menu entry, "Set as Album Thumbnail", which
> takes "S", so "Assign" gets the next available letter, "i". ("A" is taken by
> "Add to Light Table").
>

Comment 6 Dan Dascalescu 2017-01-22 20:44:43 UTC

I use the 5.5.0 appimage, but if QT assigns shortcuts automatically, that is a problem, i.e. consistent shortcuts won't be guaranteed as new menu options are added.

Is there a way to "pin" some of the shortcuts (the most important or commonly used ones) and let QT generate accelerators for the others?

Comment 7 caulier.gilles 2017-01-23 12:11:38 UTC

The way to assign key shorcuts in menu actions (contextual or not), is to use '&' prefix beofre the right key.

Ex : "Add to &Light Table" ==> key is 'L'

Gilles Caulier

Comment 8 caulier.gilles 2017-01-23 12:30:00 UTC

Git commit be046aaa7769385c5c684af9aa8edc730410ddce by Gilles Caulier.
Committed on 23/01/2017 at 12:16.
Pushed by cgilles into branch 'master'.

add default key shortcuts to assign/remove labels/tags
FIXED-IN: 5.5.0

M  +2    -1    NEWS
M  +3    -3    app/utils/contextmenuhelper.cpp

https://commits.kde.org/digikam/be046aaa7769385c5c684af9aa8edc730410ddce