Bug 375373

Summary:	unpinning an app in taskmanager, while that app inst running, doesn't work
Product:	[Plasma] plasmashell	Reporter:	Alexandre Pereira <pereira.alex>
Component:	Task Manager and Icons-Only Task Manager widgets	Assignee:	Eike Hein <hein>
Status:	RESOLVED FIXED
Severity:	normal	CC:	plasma-bugs-null
Priority:	NOR
Version First Reported In:	master
Target Milestone:	1.0
Platform:	Other
OS:	Linux
Latest Commit:	https://commits.kde.org/plasma-workspace/cc8ff3008a43aebebe1e86315fb919d1568009e9	Version Fixed/Implemented In:
Sentry Crash Report:

Description Alexandre Pereira 2017-01-21 13:40:41 UTC

Hi,

Currently in master ( 5.8.95, soon to be 5.9 ), trying to unpin an app while it is not running, doesn't work.

It does work while it is running, but not when its not.

Thanks !

Comment 1 Eike Hein 2017-01-21 13:56:31 UTC

It works fine for me, please upload a video or detailed steps to reproduce.

Comment 2 Alexandre Pereira 2017-01-21 14:06:32 UTC

Ok, I think i discovered what is happening: unpin works while app is not running, if pinning is for "all activities".

If pinning just to "one activity", it does not work.

Comment 3 Eike Hein 2017-01-22 15:19:36 UTC

Git commit cc8ff3008a43aebebe1e86315fb919d1568009e9 by Eike Hein.
Committed on 21/01/2017 at 15:17.
Pushed by hein into branch 'Plasma/5.9'.

Fix "Unpin" for tasks pinned to specific activities.

Summary:
requestRemoveLauncherFromActivities() had no code path handling
NULL_UUID.

Reviewers: #plasma, ivan

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D4233

M  +3    -0    libtaskmanager/launchertasksmodel.cpp

https://commits.kde.org/plasma-workspace/cc8ff3008a43aebebe1e86315fb919d1568009e9

Comment 4 Alexandre Pereira 2017-01-23 09:50:31 UTC

Thanks, just updated git packages and confirm it is working.

Thanks very much for the quick feedback !