| Summary: | Builds with Qt 5.7.1 fail on tests with 'kdeplatformtheme.cpp:333: undefined reference to `QDBusMenuBar::windowChanged(QWindow*, QWindow*)' | ||
|---|---|---|---|
| Product: | [Plasma] plasma-integration | Reporter: | Rik Mills <rikmills> |
| Component: | general | Assignee: | Martin Flöser <mgraesslin> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | kde, simonandric5 |
| Priority: | NOR | ||
| Version: | master | ||
| Target Milestone: | --- | ||
| Platform: | Kubuntu | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/plasma-integration/184d8b4fa947726636a5251f333b80429001455b | Version Fixed In: | |
|
Description
Rik Mills
2017-01-19 10:43:28 UTC
This should be fixed with latest latest master. At least build.kde.org is green again for both master and Plasma/5.9 (In reply to Martin Gräßlin from comment #1) > This should be fixed with latest latest master. At least build.kde.org is > green again for both master and Plasma/5.9 No, not fixed herea as far as I can see. Your CI from it's build log says it has Qt 5.7.0 Found Qt5PlatformSupport: /srv/jenkins/install/ubuntu/x86_64/g++/kf5-qt5/qt5/inst/usr/lib/libQt5PlatformSupport.a (found version "5.7.0") while KCI has 5.7.1 as referenced in the bug title I'm not the greatest with this code, but seem as if this is being triggered for failure by code includes by the conditionals like #if QT_VERSION > QT_VERSION_CHECK(5,7,0) for example in kdeplatformtheme.cpp ? Hence it fails here with Qt 5.7.1, but does not on the KDE CI? Git commit 184d8b4fa947726636a5251f333b80429001455b by David Edmundson. Committed on 20/01/2017 at 00:02. Pushed by davidedmundson into branch 'Plasma/5.9'. Enable QDBusMenuBar when compiling with Qt 5.7.0 M +2 -2 src/platformtheme/kdeplatformtheme.cpp M +1 -1 src/platformtheme/kdeplatformtheme.h https://commits.kde.org/plasma-integration/184d8b4fa947726636a5251f333b80429001455b Yep, you're right. Hopefully fixed. (In reply to David Edmundson from comment #4) > Yep, you're right. Hopefully fixed. Afraid not. That tweak to logic just makes it fail with Qt 5.7.0 on KDE CI in the same way it does with Qt 5.7.1 on kubuntu CI. The original issue/failure remains. Now from you CI log: 00:05:15 Linking CXX executable kdeplatformtheme_unittest 00:05:15 CMakeFiles/kdeplatformtheme_unittest.dir/__/src/platformtheme/kdeplatformtheme.cpp.o: In function `KdePlatformTheme::createPlatformMenuBar() const': 00:05:15 /home/jenkins/sources/plasma-integration/kf5-qt5/src/platformtheme/kdeplatformtheme.cpp:362: undefined reference to `QDBusMenuBar::windowChanged(QWindow*, QWindow*)' 00:05:15 collect2: error: ld returned 1 exit status 00:05:15 autotests/CMakeFiles/kdeplatformtheme_unittest.dir/build.make:362: recipe for target 'autotests/kdeplatformtheme_unittest' failed 00:05:15 make[2]: *** [autotests/kdeplatformtheme_unittest] Error 1 00:05:15 CMakeFiles/Makefile2:222: recipe for target 'autotests/CMakeFiles/kdeplatformtheme_unittest.dir/all' failed 00:05:15 make[1]: *** [autotests/CMakeFiles/kdeplatformtheme_unittest.dir/all] Error 2 Same failure now on Neon CI. http://build.neon.kde.org/job/xenial_unstable_plasma_plasma-integration_bin_amd64/67/consoleFull 13:43:33 CMakeFiles/kdeplatformtheme_unittest.dir/__/src/platformtheme/kdeplatformtheme.cpp.o: In function `KdePlatformTheme::createPlatformMenuBar() const': 13:43:33 /workspace/build/src/platformtheme/kdeplatformtheme.cpp:333: undefined reference to `QDBusMenuBar::windowChanged(QWindow*, QWindow*)' 13:43:33 collect2: error: ld returned 1 exit status 13:43:33 autotests/CMakeFiles/kdeplatformtheme_unittest.dir/build.make:385: recipe for target 'autotests/kdeplatformtheme_unittest' failed 13:43:33 make[4]: *** [autotests/kdeplatformtheme_unittest] Error 1 13:43:33 make[4]: Leaving directory '/workspace/build/obj-x86_64-linux-gnu' 13:43:33 CMakeFiles/Makefile2:427: recipe for target 'autotests/CMakeFiles/kdeplatformtheme_unittest.dir/all' failed 13:43:33 make[3]: *** [autotests/CMakeFiles/kdeplatformtheme_unittest.dir/all] Error 2 13:43:33 make[3]: Leaving directory '/workspace/build/obj-x86_64-linux-gnu' 13:43:33 Makefile:141: recipe for target 'all' failed 13:43:33 make[2]: *** [all] Error 2 QDBusMenuBar::windowChanged is not part of either Qt 5.7 or Qt 5.8. https://phabricator.kde.org/D3085 says there is a fork of QDBusMenuBar included, but I do not see it committed. Sorry, actually it is committed, so the issue is that the build system does not pick the local qdbusmenubar_p.h header. New rebuilds suggest this has been fixed in https://cgit.kde.org/plasma-integration.git/commit/?id=026277d1f0e383ac759c4f931f3fd04af11002ba |