Bug 375289

Summary: Unsharp mask threshold 0 not working correctly
Product: [Applications] krita Reporter: Alex <eneeen>
Component: FiltersAssignee: Krita Bugs <krita-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: halla
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Microsoft Windows   
OS: Microsoft Windows   
Latest Commit: https://commits.kde.org/krita/cad42d13cb42d6b76ce3c7a1e2d3c9ad44933117 Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: Part of depth map with visible noise

Description Alex 2017-01-19 10:40:09 UTC 
Created attachment 103526 [details]
Part of depth map with visible noise

It seems it's impossible to set threshold to 0, that there is always some threshold turned on. I've compared it with PS unsharp mask and it's similar to about 10 (of 255). Please check on attached file, it contains nice noise that shows problem.
Comment 1 Halla Rempt 2017-11-26 12:49:15 UTC 
Git commit cad42d13cb42d6b76ce3c7a1e2d3c9ad44933117 by Boudewijn Rempt.
Committed on 26/11/2017 at 12:49.
Pushed by rempt into branch 'master'.

Compare using >= instead of > for threshold

Also et the defaults of the unsharp mask filter to match photoshop
Note: photoshop's amount 200 is our amount 2.

M  +4    -4    plugins/filters/unsharp/kis_unsharp_filter.cpp
M  +1    -1    plugins/filters/unsharp/wdgunsharp.ui

https://commits.kde.org/krita/cad42d13cb42d6b76ce3c7a1e2d3c9ad44933117