| Summary: | Group popup is height-limited but not scrollable | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Dan <dcoffey095> |
| Component: | Task Manager and Icons-Only Task Manager widgets | Assignee: | Eike Hein <hein> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | notmart, plasma-bugs-null |
| Priority: | NOR | ||
| Version First Reported In: | 5.8.5 | ||
| Target Milestone: | 1.0 | ||
| Platform: | Ubuntu | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/plasma-desktop/f6b30cb08d4cf2b45f1e1315b1b1bd681a0073a8 | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
| Attachments: |
attachment-17723-0.html
Cropped group popup (from dropbox) |
||
|
Description
Dan
2017-01-17 20:45:14 UTC
the description of the problem is not clear, can you provide a screenshot? Can you attach a screenshot? I have 24 firefox instances open, they all show up when not grouped. The grouped list is missing several of the firefox instances. The grouping worked before the last plasmashell upgrade. Dan 321 210 1844 On 01/18/2017 08:00 AM, Marco Martin wrote: > https://bugs.kde.org/show_bug.cgi?id=375196 > > Marco Martin <notmart@gmail.com> changed: > > What |Removed |Added > ---------------------------------------------------------------------------- > CC| |notmart@gmail.com > > --- Comment #1 from Marco Martin <notmart@gmail.com> --- > the description of the problem is not clear, can you provide a screenshot? > Created attachment 103484 [details] attachment-17723-0.html I have 24 firefox instances open, they all show up when not grouped. The grouped list is missing several of the firefox instances. The grouping list worked before the last plasmashell upgrade. Link to images Dropbox <https://www.dropbox.com/sh/dpn8i4m72e9uvub/AABNqjvFuzWSYog7Z7sNsbwEa?dl=0> Dan 321 210 1844 On 01/18/2017 08:44 AM, Eike Hein wrote: > https://bugs.kde.org/show_bug.cgi?id=375196 > > Eike Hein <hein@kde.org> changed: > > What |Removed |Added > ---------------------------------------------------------------------------- > Resolution|--- |WAITINGFORINFO > Status|UNCONFIRMED |NEEDSINFO > > --- Comment #2 from Eike Hein <hein@kde.org> --- > Can you attach a screenshot? > Created attachment 103537 [details]
Cropped group popup (from dropbox)
Confirmed.
Possibly caused by the larger icons in the group popup, but not accounting for their new size when computing sizes.
Setting status correctly. Hmm I renamed the bug earlier already, but somehow it didn't stick, or I renamed the wrong ticket ... Anyway, I'm currently working on a rewrite of the group popup dialog that makes it scrollable, along with fixing wheel support and improving the sizing code. Patch under review: https://phabricator.kde.org/D4229 Git commit f6b30cb08d4cf2b45f1e1315b1b1bd681a0073a8 by Eike Hein. Committed on 25/01/2017 at 17:03. Pushed by hein into branch 'master'. Overhaul group popup dialog Summary: A set of UI improvements to the group popup dialog: * The dialog was height-limited but not scrollable. It now shows a vertical scrollbar if needed. * The existing keyboard handling is extended to scroll any item navigated to by keyboard into view. * At opening time (before the dialog causes a change in window focus) the currently-active task (if any) is collected, and then made the active item, scrolling it into view if needed. Keyboard nav will then start there. This improves initial focus handling. * The normal wheel-handling is short-circuited in favor of scrolling when the dialog overflows. Reviewers: #plasma Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D4229 M +3 -1 applets/taskmanager/package/contents/ui/ContextMenu.qml M +105 -22 applets/taskmanager/package/contents/ui/GroupDialog.qml M +14 -2 applets/taskmanager/package/contents/ui/MouseHandler.qml M +7 -3 applets/taskmanager/package/contents/ui/Task.qml M +12 -0 applets/taskmanager/package/contents/ui/main.qml https://commits.kde.org/plasma-desktop/f6b30cb08d4cf2b45f1e1315b1b1bd681a0073a8 |