Bug 375125

Summary:	Settings window resizes itself when "CDDB" section is clicked
Product:	[Applications] k3b	Reporter:	Patrick Silva <bugseforuns>
Component:	GUI/Usability	Assignee:	k3b developers <k3b>
Status:	REOPENED ---
Severity:	normal	CC:	lueck, michalm, pino, simonandric5, trueg, zhaixiang
Priority:	NOR
Version:	19.12
Target Milestone:	---
Platform:	Arch Linux
OS:	Linux
Latest Commit:	https://commits.kde.org/k3b/828891b2cbba66f8503805646193728901e40af4	Version Fixed In:
Sentry Crash Report:

Description Patrick Silva 2017-01-16 03:06:41 UTC

Open settings dialog in k3b, click on "CDDB" in left side
Result: settings dialog resizes itself.

I'm running k3b-git on Arch from aur repository.

Comment 1 Burkhard Lück 2017-01-16 08:05:18 UTC

k3b build from sources 
Version 17.04.00
KDE Frameworks 5.31.0
Qt 5.6.1 (built against 5.6.1)
not reproducible for me

What are your versions?
Why did you select component "Data Project"? I see no relation to this bug.

Comment 2 Patrick Silva 2017-01-16 12:59:38 UTC

Sorry, I have changed to the correct component.

I'm running k3b 17.04, kde frameworks 5.29, Qt 5.8 (built against 5.7.1)

I recorded a screencast
https://www.youtube.com/watch?v=BPwI0SBOHxg

Comment 3 Burkhard Lück 2017-01-16 15:52:35 UTC

On your screencast I see the issue now and it is reproducible here

Comment 4 Leslie Zhai 2017-03-14 08:03:43 UTC

Git commit 828891b2cbba66f8503805646193728901e40af4 by Leslie Zhai.
Committed on 14/03/2017 at 08:01.
Pushed by lesliezhai into branch 'master'.

Fix Settings dialog resizes itself issue

M  +1    -1    src/option/k3boptiondialog.cpp

https://commits.kde.org/k3b/828891b2cbba66f8503805646193728901e40af4

Comment 5 Pino Toscano 2018-01-04 10:19:37 UTC

I do not think this is a correct fix.  Now the config dialog has a fixed size, and cannot be resized at all: this is bad for usability, since it truncates labels of checkboxes, texts in list views, and so on.

I reverted it, and thus reopened this bug.

Comment 6 Leslie Zhai 2018-01-07 01:07:56 UTC

(In reply to Pino Toscano from comment #5)
> I do not think this is a correct fix.  Now the config dialog has a fixed
> size, and cannot be resized at all: this is bad for usability, since it
> truncates labels of checkboxes, texts in list views, and so on.
> 
> I reverted it, and thus reopened this bug.

Sorry for my dirty patch...

Comment 7 Leslie Zhai 2018-01-07 01:11:45 UTC

(In reply to Leslie Zhai from comment #6)
> (In reply to Pino Toscano from comment #5)
> > I do not think this is a correct fix.  Now the config dialog has a fixed
> > size, and cannot be resized at all: this is bad for usability, since it
> > truncates labels of checkboxes, texts in list views, and so on.
> > 
> > I reverted it, and thus reopened this bug.
> 
> Sorry for my dirty patch...

I think it is better to code review firstly, if LGTM by Pino, then I git push :)