| Summary: | Cumulative undo not working | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | Manga Tengu <mangatengu> |
| Component: | General | Assignee: | Dmitry Kazakov <dimula73> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | acc4commissions, dimula73, freebox64, halla, karpi.web, patricia.moncorge, rjquiralte, tomtomtomreportingin, tysontanx |
| Priority: | NOR | ||
| Version First Reported In: | 3.1.1 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/graphics/krita/commit/46469ed37c4d602f4826d307e857466ea542ab64 | Version Fixed In: | |
| Sentry Crash Report: | |||
|
Description
Manga Tengu
2017-01-15 01:37:26 UTC
This is also present on master branch, can confirm the same behavior. (linux here too) Hi, confirming the issue on Ubuntu 14.04 with Krita 3.1.1 Appimage. Git commit 61dcdf5c81651b7324da98796e9b60eb695c6de5 by Boudewijn Rempt. Committed on 17/01/2017 at 10:32. Pushed by rempt into branch 'master'. M +5 -5 plugins/dockers/historydocker/DlgConfigureHistoryDock.cpp M +2 -1 plugins/dockers/historydocker/DlgConfigureHistoryDock.h M +1 -1 plugins/dockers/historydocker/HistoryDock.cpp https://commits.kde.org/krita/61dcdf5c81651b7324da98796e9b60eb695c6de5 Git commit 152862cb4aeac4eb98af3058daabae0a566a195a by Boudewijn Rempt. Committed on 17/01/2017 at 10:33. Pushed by rempt into branch 'krita/3.1'. M +5 -5 plugins/dockers/historydocker/DlgConfigureHistoryDock.cpp M +2 -1 plugins/dockers/historydocker/DlgConfigureHistoryDock.h M +1 -1 plugins/dockers/historydocker/HistoryDock.cpp https://commits.kde.org/krita/152862cb4aeac4eb98af3058daabae0a566a195a In V3.1.2 the bug is not fixed yet The checkbox is saved, but the effect is not there *** Bug 376559 has been marked as a duplicate of this bug. *** I'm confirming in version 4.0.2 FYI Cumulative Undo is still not working on Krita 4.1.0 neither 4.1.1 (AppImage) (In reply to Patricia Moncorgé from comment #9) > FYI Cumulative Undo is still not working on Krita 4.1.0 neither 4.1.1 > (AppImage) Thanks for the notice, but yeah, that is why this still marked as "confirmed" and not as "fixed resolved", it means still is in the queue till the devs can work on it :) *** Bug 409974 has been marked as a duplicate of this bug. *** Translating the documentation. I can confirm it's still broken. Also, the documentation doesn't match the current UI. Additional note: The "Split Strokes" setting doesn't appear to be configurable as it's reset to some sort of default after closing the configuration dialog. This patch should solve the issue: https://invent.kde.org/graphics/krita/-/merge_requests/834 Git commit cc8e37f64e46b31992d4e65497296681ab06a678 by Dmitry Kazakov. Committed on 13/05/2021 at 10:41. Pushed by dkazakov into branch 'master'. Recover cumulative undo/redo support (it was lost during a merge operation in 2015...) M +2 -1 libs/ui/tool/kis_tool_freehand_helper.cpp M +2 -0 libs/ui/tool/strokes/freehand_stroke.cpp M +2 -1 libs/ui/tool/strokes/freehand_stroke.h M +14 -4 libs/ui/tool/strokes/kis_painter_based_stroke_strategy.cpp M +5 -2 libs/ui/tool/strokes/kis_painter_based_stroke_strategy.h https://invent.kde.org/graphics/krita/commit/cc8e37f64e46b31992d4e65497296681ab06a678 Git commit 46469ed37c4d602f4826d307e857466ea542ab64 by Dmitry Kazakov. Committed on 13/05/2021 at 10:41. Pushed by dkazakov into branch 'master'. Fix order of execution of undo commands with cumulative undo M +11 -10 libs/command/kundo2stack.cpp https://invent.kde.org/graphics/krita/commit/46469ed37c4d602f4826d307e857466ea542ab64 Thank you Dmitry! :D |