Bug 374897

Summary:	Wrong test for empty locations after directory filtering in MercurialPlugin::add
Product:	[Developer tools] kdevplatform	Reporter:	Frank Fischer <frank-fischer>
Component:	mercurial	Assignee:	kdevelop-bugs-null
Status:	RESOLVED FIXED
Severity:	minor	CC:	frank-fischer, kalinichev.so.0
Priority:	NOR
Version First Reported In:	git master
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://commits.kde.org/kdev-mercurial/25277ccfb043c8b51349bbf95c35e53c27a8704e	Version Fixed/Implemented In:
Sentry Crash Report:

Description Frank Fischer 2017-01-11 07:55:58 UTC

The condition `if (localLocations.empty())` in method MercurialPlugin::add (line 201 in the current master) should probably be `if (locations.empty())` (as it is in many other methods).

Comment 1 Sergey Kalinichev 2017-01-17 15:46:40 UTC

Git commit 25277ccfb043c8b51349bbf95c35e53c27a8704e by Sergey Kalinichev.
Committed on 15/01/2017 at 13:34.
Pushed by vpuhov into branch 'master'.

Fix MercurialPlugin::add in non-recursive case

Spotted by Frank Fischer

M  +1    -1    mercurialplugin.cpp
M  +3    -0    tests/test_mercurial.cpp

https://commits.kde.org/kdev-mercurial/25277ccfb043c8b51349bbf95c35e53c27a8704e