Bug 374843

Summary: color-management.svg has undefined links in some sizes
Product: [Plasma] Breeze Reporter: Christian (Fuchs) <kde>
Component: IconsAssignee: visual-design
Status: RESOLVED FIXED    
Severity: normal CC: kainz.a
Priority: NOR    
Version First Reported In: 5.8.5   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:

Description Christian (Fuchs) 2017-01-09 22:26:54 UTC
Hi, 

I use the color-management.svg icon in a plasmoid of mine, and it spews tons of warnings about 

link r hasn't been detected!
link s hasn't been detected!

turns out that in some sizes  (16 and 32, apparently) there is a <use xlink:href .. on these two, but no matching definition. 

Could you please fix that? 

Thanks in advance, kind regards, 

Fuchs
Comment 1 andreas 2017-01-15 20:10:49 UTC
Git commit c3bfa08cc839b0e0de1e768f82adb06593ff26d1 by andreas kainz.
Committed on 15/01/2017 at 20:10.
Pushed by andreask into branch 'master'.

update color-management icon

M  +406  -100  icons-dark/actions/16/color-management.svg
M  +406  -100  icons-dark/actions/32/color-management.svg
A  +1    -0    icons-dark/actions/32/colormanagement.svg
M  +406  -100  icons/actions/16/color-management.svg
M  +406  -100  icons/actions/32/color-management.svg
A  +1    -0    icons/actions/32/colormanagement.svg

https://commits.kde.org/breeze-icons/c3bfa08cc839b0e0de1e768f82adb06593ff26d1
Comment 2 andreas 2017-01-15 20:11:41 UTC
please check if it work for you. I didn't have an idea how to fix it. I use now Inkscape so maybe it worked, but I'm not sure.
Comment 3 Christian (Fuchs) 2017-01-15 22:55:01 UTC
Hi Andreas, 

I'm afraid that doesn't fix it (tested by manually downloading the new one as binary blob and replacing it), as you can see in the SVG source, it still references #s and #r, which both don't exist, so it spews out a warning. It is probably possible just re-create the icon from a size that isn't affected, e.g. 24 or 22. Given it's a scalable svg, that's probably the best option. 

Thanks in advance, kind regards, 

Christian
Comment 4 andreas 2017-02-05 23:44:51 UTC
Git commit 1e7b3672731a1ceae4fea581a14f4cc0f094105f by andreas kainz.
Committed on 05/02/2017 at 23:43.
Pushed by andreask into branch 'master'.

color-management removed undefined links hopefully

M  +292  -333  icons-dark/actions/16/color-management.svg
M  +265  -340  icons-dark/actions/32/color-management.svg
M  +292  -333  icons/actions/16/color-management.svg
M  +265  -340  icons/actions/32/color-management.svg

https://commits.kde.org/breeze-icons/1e7b3672731a1ceae4fea581a14f4cc0f094105f