| Summary: | No dialogue opening on edit bookmarks in geolocation editor | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | Martin <mf> |
| Component: | Geolocation-Bookmarks | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | caulier.gilles, freisim93, gsking1, hardy.public |
| Priority: | NOR | ||
| Version: | 5.3.0 | ||
| Target Milestone: | --- | ||
| Platform: | Microsoft Windows | ||
| OS: | Microsoft Windows | ||
| Latest Commit: | https://commits.kde.org/digikam/95b5cec4970939d5068ca13ce3e3198fc929cc5b | Version Fixed In: | 5.6.0 |
| Sentry Crash Report: | |||
| Attachments: | Screenshot of the menu entry, which does nothing | ||
*** Bug 374841 has been marked as a duplicate of this bug. *** In fact the BookMark editor sound like relevant of another run time dependency. It's not started through KF5 framework directly using shared library. This require to install another amount of KDE for only a single feature. We don't want to do it. So i will disable this feature for MacOS and Windows. Linux sound to work properly here with AppImage (it start the KDE4 bookmark editor on KDE4 desktop). Gilles Caulier For me it does not work with the appimage bundle in linux (debian). As described nothing happens and there is also nothing in the log. For me, AppImage provide BookMark editor dialog because my desktop is KDE4. I think the runtime is resolved if whole KDE is installed. This is not mandatory to have KDE desktop running, only runtime dependency resolved. But as i said this is again the KDE puzzle at runtime... Gilles Caulier I'm using digikam 5.4 on both Windows and Mac and have this issue. I like the direction digikam has taken recently to make a single easy to install package for all OS's and can not install all of KDE on these machines. As a workaround this is how to manually edit the bookmark titles: Windows 7 bookmarks file "geobookmarks.xml" is here: C:\Users\USERNAME\AppData\Local\digikam Close digikam Open geobookmarks.xml in editor Edit text associated with "<title>" in geobookmarks.xml file Remove geobookmarks.tbcache file if present Restart digikam In all case bookmarks from KF5::Bookmarks must be disabled under OSX and Windows, to not depend of KDE runtime. But i think we can have an alternative. Look over the map provided by Marble (not googlemaps). Right click give another context menu with also a bookmark feature. This is marble component, not KF5::Bookmarks. We can certainly use this one instead, if feature is the similar. Gilles Caulier *** Bug 376407 has been marked as a duplicate of this bug. *** *** This bug has been marked as a duplicate of bug 376074 *** Git commit 112215b78a7cc9679a050c470444543b9db3a60b by Gilles Caulier. Committed on 15/05/2017 at 15:29. Pushed by cgilles into branch 'master'. add new GPS bookmarks manager for Geolocation Editor remove KF5::Bookmarks dependency which do not wrok with AppImage, MacOS bundle and Windows installer, due to run-time dependencies and DBus requirements. Implementation is not yet finalized and need to be polished before 5.6.0 release, especially to be able to import older GPS bookmarks generated by DK < 5.6.0 Related: bug 376687, bug 376391, bug 376074, bug 376407 M +0 -3 CMakeLists.txt M +0 -4 app/CMakeLists.txt M +8 -18 utilities/geolocation/editor/CMakeLists.txt A +273 -0 utilities/geolocation/editor/bookmark/bookmarknode.cpp [License: GPL (v2+)] A +114 -0 utilities/geolocation/editor/bookmark/bookmarknode.h [License: GPL (v2+)] A +325 -0 utilities/geolocation/editor/bookmark/bookmarksdlg.cpp [License: GPL (v2+)] A +132 -0 utilities/geolocation/editor/bookmark/bookmarksdlg.h [License: GPL (v2+)] A +301 -0 utilities/geolocation/editor/bookmark/bookmarksmenu.cpp [License: GPL (v2+)] A +137 -0 utilities/geolocation/editor/bookmark/bookmarksmenu.h [License: GPL (v2+)] A +726 -0 utilities/geolocation/editor/bookmark/bookmarksmngr.cpp [License: GPL (v2+)] A +236 -0 utilities/geolocation/editor/bookmark/bookmarksmngr.h [License: GPL (v2+)] M +37 -25 utilities/geolocation/editor/bookmark/gpsbookmarkmodelhelper.cpp M +17 -11 utilities/geolocation/editor/bookmark/gpsbookmarkmodelhelper.h M +63 -52 utilities/geolocation/editor/bookmark/gpsbookmarkowner.cpp M +20 -18 utilities/geolocation/editor/bookmark/gpsbookmarkowner.h M +7 -40 utilities/geolocation/editor/dialog/geolocationedit.cpp M +14 -31 utilities/geolocation/editor/items/gpsimagelistcontextmenu.cpp M +3 -9 utilities/geolocation/editor/items/gpsimagelistcontextmenu.h M +6 -25 utilities/geolocation/editor/searches/searchwidget.cpp M +1 -7 utilities/geolocation/editor/searches/searchwidget.h https://commits.kde.org/digikam/112215b78a7cc9679a050c470444543b9db3a60b Git commit 95b5cec4970939d5068ca13ce3e3198fc929cc5b by Gilles Caulier. Committed on 17/05/2017 at 10:04. Pushed by cgilles into branch 'master'. remove menu and toolbar bookmarks management from GPS bookmarks manager. Now a first version suitable is available. More improvements will come later. Import form older GPS bookmarks generated bu KF5::bookmarks run fine as well. Related: bug 376687, bug 376074, bug 376391, bug 376407 FIXED-IN: 5.6.0 M +11 -5 utilities/geolocation/editor/bookmark/bookmarksdlg.cpp M +2 -2 utilities/geolocation/editor/bookmark/bookmarksmenu.cpp M +6 -123 utilities/geolocation/editor/bookmark/bookmarksmngr.cpp M +0 -2 utilities/geolocation/editor/bookmark/bookmarksmngr.h M +1 -1 utilities/geolocation/editor/bookmark/gpsbookmarkowner.cpp M +23 -19 utilities/geolocation/editor/items/gpsimagelistcontextmenu.cpp https://commits.kde.org/digikam/95b5cec4970939d5068ca13ce3e3198fc929cc5b |
Created attachment 103273 [details] Screenshot of the menu entry, which does nothing Hi, after an update from digikam 4.12.0 up to 5.3.0 the Feature "Bookmarks - Edit Bookmarks" in the "Item - Edit Geolocation" doesn't work. It happens exactly nothing. Under 4.12.0 a Dialog appears, where I can rename / reorder the single bookmark items. While Installation and first Startup, there was a "old marble" Installation found and by he question "convert to use" I said "Yes". One the globe I see no geo Information, so I think, there is a Problem with this converted Marble. Switching the globe to Google Maps shows the streets, but the edit bookmark Feature has the same Problem. Thanks for help. Additional: After switching the language from "Deutsch" to "American English" and a program stop and start, I can see the entry "Neuer Lesezeichenordner" instead of "New Folder", see attachment