Bug 374616

Summary: Visibility of association role name labels are not updated
Product: [Applications] umbrello Reporter: Ralf Habacker <ralf.habacker>
Component: generalAssignee: Umbrello Development Group <umbrello-devel>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version: 2.21.0 (KDE Applications 16.12.0)   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: https://commits.kde.org/umbrello/83cbf8ae1eb39314ef9b6b1e093d943648c29ef9 Version Fixed In: 2.21.2 (KDE Applications 16.12.2)

Description Ralf Habacker 2017-01-06 00:10:51 UTC 
How to reproduce:
1. start umbrello
2. add two classes to a diagram named A and B
3. add attribute a of type B to class A
-> the association role name label of B end shows '-b' which indicates private visibility.
4. double click on attribute b in tree view, change visibility to public and press okay
-> the association role name label of B end still shows '-b'.

What is expected:
The association role name label of B end should show the correct visibility
Comment 1 Ralf Habacker 2017-01-09 00:45:19 UTC 
Git commit 60d94f8fef1220f23701dacba59d2668cc93ff70 by Ralf Habacker.
Committed on 09/01/2017 at 00:44.
Pushed by habacker into branch 'Applications/16.12'.

Avoid obsolates writes of AssociationWidget property settings on applying.

Obsolates writes are in in setText() and in setVisibility() where a
signal/slot loopback from UMLAssociation|UMLAttribute::setVisibility()
was present.

M  +12   -24   umbrello/umlwidgets/associationwidget.cpp

https://commits.kde.org/umbrello/60d94f8fef1220f23701dacba59d2668cc93ff70
Comment 2 Ralf Habacker 2017-01-09 00:45:19 UTC 
Git commit 83cbf8ae1eb39314ef9b6b1e093d943648c29ef9 by Ralf Habacker.
Committed on 09/01/2017 at 00:44.
Pushed by habacker into branch 'Applications/16.12'.

Fix 'Visibility of association role name labels are not updated'.

In AssociationWidget::setVisibility() make sure that prefix text
of role name widget is set unconditional and also make sure that
the related ClassifierWidget is signaled only on calling
UMLAttribute::setName().
FIXED-IN:2.21.2 (KDE Applications 16.12.2)

M  +6    -6    umbrello/dialogs/umlattributedialog.cpp
M  +1    -4    umbrello/umlwidgets/associationwidget.cpp

https://commits.kde.org/umbrello/83cbf8ae1eb39314ef9b6b1e093d943648c29ef9