Bug 374508

Summary:	Dolphin overwrites Hidden icons toolbar button icon
Product:	[Applications] dolphin	Reporter:	jacob.becker
Component:	general	Assignee:	Dolphin Bug Assignee <dolphin-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	kde
Priority:	NOR
Version First Reported In:	16.08.3
Target Milestone:	---
Platform:	openSUSE
OS:	Linux
Latest Commit:	https://commits.kde.org/dolphin/85121a8115c5a8b6b7c0a01073663d51bd64e6ae	Version Fixed In:	16.12.2
Sentry Crash Report:

Description jacob.becker 2017-01-03 19:35:41 UTC

I have the following strange behavior of the dolphin toolbar in Tumbleweed as well as in Leap 42.2

Open toolbar configuration

1) select "hidden files" an place it behind a seperator.
2) give the "hidden files" entry a symbol (symbol chosen does not matter)
3) apply settings

The symbol (an the text if that is your setting) is shown in the toolbar

However, if the symbol is clicked, the symbol disappears an the text "hidden files" is shown without a symbol.

To me that looks like a Bug.

Comment 1 Kai Uwe Broulik 2017-01-04 21:49:28 UTC

The tool bar button should have an "eye" icon, though. When toggling the action, Dolphin updates the icon, overriding it.

Comment 2 jacob.becker 2017-01-06 02:27:29 UTC

I see.
 It does have the "eye" icon in the breeze icon theme , but not in other themes.
So Oxygen and the other are missing a symbol for this funktion.
But on the other hand.
If i manually set the symbol to something other than default (the eye) the issue remains. All other symbols than the default are overwritten at first click.

Comment 3 Elvis Angelaccio 2017-01-14 11:57:52 UTC

Git commit 85121a8115c5a8b6b7c0a01073663d51bd64e6ae by Elvis Angelaccio.
Committed on 14/01/2017 at 11:52.
Pushed by elvisangelaccio into branch 'Applications/16.12'.

Don't overwrite custom icons for the show_hidden_files action
FIXED-IN: 16.12.2
REVIEW: 129789

M  +6    -0    src/views/dolphinviewactionhandler.cpp

https://commits.kde.org/dolphin/85121a8115c5a8b6b7c0a01073663d51bd64e6ae