Bug 374335

Summary:	System Tray: improve behavior
Product:	[Plasma] plasmashell	Reporter:	rockonthemoonfm
Component:	System Tray widget	Assignee:	Plasma Bugs List <plasma-bugs>
Status:	RESOLVED FIXED
Severity:	minor	CC:	kde, kishore96, simonandric5, thomas.pfeiffer
Priority:	NOR	Flags:	kde: Usability?
Version:	master
Target Milestone:	1.0
Platform:	Other
OS:	Linux
Latest Commit:	https://commits.kde.org/plasma-workspace/04ed182cf10a86e16ff28f97026590ca2804c136	Version Fixed In:
Sentry Crash Report:

Description rockonthemoonfm 2016-12-30 13:44:36 UTC

When you click on a Item in System Tray, the tray slides up to shows its widget.
At the same time, the triangle-arrow on the right makes a 180° turn to indicate that the tray is open.
There lays the problem in my opinion.
The triangle-arrow should not indicate that the tray is obviously opened or obviously closed.
The triangle-arrow should just act as the button to show the hidden Items.
Actually, if you click on an Item and its widget slides up and if you click on the triangle-arrow to see the hidden Items, as a result you get the widget that slides down. You have to click on the triangle-arrow again to slide up the hidden Items widget.

So my proposal is
- to not always animate the triangle-arrow, but only when the hidden Items widget slides up or down
- the triangle-arrow should work only as a button for hidden Items, not as a button to close other Items' widget.

Comment 1 Thomas Pfeiffer 2017-01-01 22:53:02 UTC

The tooltip over the triangle button when the popup was opened by a widget says "Hide icons" which is misleading in this case because it does not hide icons.

On the other hand, having a button to close the popup may still be a nice thing, and I don't see having to click the button twice to reveal the hidden uicons when a popup is open as too much of a problem.

Therefore, I'd keep the behavior as it is and just change the tooltip to "Close popup" when it is opened regardless of the reason.

Comment 2 rockonthemoonfm 2017-01-02 12:11:38 UTC

Actually what you say it's something like: "it's perfect just as it is, no room for improvement" and, well, I disagree.

To close a popup you don't need a special triangle button with the DOUBLE function of closing popups AND showing hidden widgets.

You can click the respective HIGHLIGHTED icon (battery popup open? Click again on the highlighted battery icon to close it, logic!) AND you can click ANYWHERE else in the workspace to close it too!

Also, keeping the behaviour as it is doesn't solve the visual glitch of not having an animated transition from an opened popup to the hidden icons tray. You have to close the tray and popup goes down, then you have to click again and popup goes up: verbose.

We can improve animations too: if I click an icon on the left of the systray and then I click on one at the right, I expect an animated transition of the popup from left to right. If I click an icon on the right of the systray and then I click on one at the left, I expect an animated transition of the popup from right to left.

Maybe someone can agree with what I suggest.

Anyways.. Happy new year! :D

Comment 3 David Edmundson 2017-01-09 02:53:02 UTC

Git commit 04ed182cf10a86e16ff28f97026590ca2804c136 by David Edmundson.
Committed on 09/01/2017 at 02:52.
Pushed by davidedmundson into branch 'master'.

Rename expander icon tooltip to "close popup" to close the popup

Summary:
Quoting Thomas from the bug report:

>The tooltip over the triangle button when the popup was opened by a
widget says "Hide icons" which is misleading in this case because it
does not hide icons.

>Therefore, I'd keep the behavior as it is and just change the tooltip
to "Close popup" when it is opened regardless of the reason.

Reviewers: #plasma, mart

Reviewed By: mart

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D3914

M  +1    -1    applets/systemtray/package/contents/ui/ExpanderArrow.qml

https://commits.kde.org/plasma-workspace/04ed182cf10a86e16ff28f97026590ca2804c136