Bug 374248

Created attachment 103040 [details]
dolphin file selector

digiKam use Qt5 dialog to be compatible everywhere. KDE dialog is deprecated since version 5


Gilles Caulier

ok for a qt file selector
but
you don't answer about populating it with user and system shortcut
and in particular
bluedevil or kdeconnect shortcut

As i know, Qt5 file dialog do not permit this yet.

If you want this feature report as upstream to Qt bugzilla.

Note : the screenshot that you provide is a dolphin main view, not a file dialog.

Gilles Caulier

Created attachment 103042 [details]
true dolphin file_selector

treu dolphin file selector

you cab see it is the same thing about shortcuts

qt answer
here https://bugreports.qt.io/browse/QTBUG-57828

"This is not a Qt problem at all. The KDE theme plugin didn't get loaded."

I'm not wrong. I check GwenView code. Open/File give a similar dialog that you attach in this report. Gwenview code use KFileDialog, which is relevant of KDELibsSupport.

digiKam is a pure Qt5/KF5 application. We drop all KDE4 deprecated API. We will not go back. Never.

If Qt5::QFileDialog support native theme, why not. But here this do not work.

In digiKam we have QFileDialog option DontUseNativeDialog turned on, which must be disabled in this case. I will patch source code in this way. But as i said, this do not change anything here. Perhaps something need to be installed in Plasma desktop to take effect. I don't know.

Gilles Caulier

Git commit 0a5615d18d5e697e19e5c90fea1e3e4987e2db2c by Gilles Caulier.
Committed on 28/12/2016 at 14:20.
Pushed by cgilles into branch 'master'.

permit to use native file dialog

M  +0    -1    app/main/digikamapp.cpp
M  +0    -1    libs/dialogs/imagedialog.cpp
M  +7    -4    libs/widgets/common/dwidgetutils.cpp
M  +1    -1    utilities/assistants/firstrun/collectionpage.cpp
M  +0    -1    utilities/imageeditor/editor/editorwindow.cpp

https://commits.kde.org/digikam/0a5615d18d5e697e19e5c90fea1e3e4987e2db2c

please if you have technical argument please discuss with qt team.
i suppplied the address of the qt answer. there is the address of the person who answered.

don't play ping pong with me.

i am not a techie. i am only a user who want an app easy to use.

thanks

Gilles,

The native file dialog works here under openSUSE. I see the KDE file dialog. But see Bug 373820. If the native file dialog under Debian problem makes, we get a problem with digiKam-5.4.0 release. My suggestion, we use for digiKam-5.4.0 the pure Qt file dialog. And look for a way to recognize the running desktop (possible with Qt >= 5.7.0) and use only the native file dialog if a Plasma desktop is present.

Maik

Hi Maik, and Happy new year...

I don't know if Plasma desktop detection was possible with Qt5.7. This work around is fine for me.

Gilles

Gilles,

Thanks, Happy New Year to you. You're right there is no way with Qt-5.7.0 to recognize the desktop. I find another way.

Maik

Maik,

Dbus can be a solution. Not perfect so far, but look here :

https://cgit.kde.org/digikam.git/tree/libs/notificationmanager/dnotificationwrapper.cpp#n87

Take a care : Dbus is optional in digiKam.

Gilles

there is no more problem in my case with digikam 5.4.0

i re-open this bug report

opensuse 42.3
kde apps 17.12.0
kde framework 5.40
qt 5.10.0

problem re-appears with 5.7.0 and still there with 5.8 2017 12 12

Please look in the digiKam settings under miscellaneous. There you can activate the system file dialog.

Maik

Created attachment 109386 [details]
digikam settings miscellaneaous

digikam 5.7.0 (rpm)

there is nothing about "file system dialog" in "miscellaneous"

Fixed in digiKam-5.8.0.

Maik

digikam 5.8.0 2017 12 12 bundle

i check "use system file dialog"
then
i import file or folder
then
no system file dialog

I'll check it again with the AppImage tonight. But it works with the native version for Linux / Mac / Windows. I also use the system file dialogs.

Maik

Ok, AppImage does not include the Qt-Plugins for native file dialogs. I do not think we will change that, we would also have to include the dialogue for GTK, for example. DigiKam-5.8.0 will be released next week.

Maik

Maik,

Qt-Plugins for native file dialogs ? I don't know this feature was supported by a plugin.

Which one exactly ? Has i compile the whole Qt5 bundle as well, with some tune at configuration time, this can be certainly fixed quickly if i know which option i need to turn on.

https://cgit.kde.org/digikam-software-compilation.git/tree/project/bundles/3rdparty/ext_qt/CMakeLists.txt

Or perhaps it's an extra source code provided outside Qt ? If yes, it can be easy to add the code to compile from the main rules with cmake. As i use Centos6, all GTK is already here. I think it can be easy to do.

Gilles

As an example for my openSUSE:

Support for GTK3:
/usr/lib64/qt5/plugins/platformthemes/libqgtk3.so

GTK2:
/usr/lib64/qt5/plugins/platformthemes/libqgtk2.so

KF5 Plasma:
/usr/lib64/qt5/plugins/platformthemes/KDEPlasmaPlatformTheme.so

If I remove the KF5 plugin, I only have a Qt file dialog.

Maik

Ok, i see... I will take a look while this week end.

Gilles

The *gtk* platforms plugins sound like generated by qt5core if gtk dependencies are enabled (currently no).

I will integrated this for later 5.9.0 release when i will update Qt5 to last stable 5.10.0.

Gilles Caulier