Summary: | Code Importing Wizard - broken file selection (doesn't let me import what I select) | ||
---|---|---|---|
Product: | [Applications] umbrello | Reporter: | alexandru.chirita4192 |
Component: | importer | Assignee: | Umbrello Development Group <umbrello-devel> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | alexandru.chirita4192, okellogg, ralf.habacker, simonandric5 |
Priority: | NOR | ||
Version: | 2.21.0 (KDE Applications 16.12.0) | ||
Target Milestone: | --- | ||
Platform: | Microsoft Windows | ||
OS: | Microsoft Windows | ||
Latest Commit: | https://invent.kde.org/kde/umbrello/commit/0459a7368321d69b8cb567142ad82601477575c1 | Version Fixed In: | 2.30.2 (KDE Applications 19.12.2) |
Attachments: | You can see actual selected files vs. "Number of files" vs files which get imported. I cannot import what I select (but "Number of files" and the actual imported files are correlated) |
Description
alexandru.chirita4192
2016-12-24 18:39:34 UTC
Git commit 0459a7368321d69b8cb567142ad82601477575c1 by Oliver Kellogg. Committed on 11/01/2020 at 05:02. Pushed by okellogg into branch 'release/19.12'. Fix broken file selection for PHP and SQL in code import wizard: umbrello/codeimpwizard/codeimpselectpage.cpp - In changeLanguage() handle all cases of Uml::ProgrammingLanguage enum. Related: bug 335566 FIXED-IN:2.30.2 (KDE Applications 19.12.2) M +38 -3 umbrello/codeimpwizard/codeimpselectpage.cpp https://invent.kde.org/kde/umbrello/commit/0459a7368321d69b8cb567142ad82601477575c1 (In reply to Oliver Kellogg from comment #1) > Git commit 0459a7368321d69b8cb567142ad82601477575c1 by Oliver Kellogg. > Committed on 11/01/2020 at 05:02. > Pushed by okellogg into branch 'release/19.12'. > > Fix broken file selection for PHP and SQL in code import wizard: Just an info - you fixed the extensions in https://invent.kde.org/kde/umbrello/blob/0459a7368321d69b8cb567142ad82601477575c1/umbrello/codeimpwizard/codeimpselectpage.cpp#L332, which are a duplicate of Uml::ProgrammingLanguage::toExtensions(Enum item), see https://invent.kde.org/kde/umbrello/blob/0459a7368321d69b8cb567142ad82601477575c1/umbrello/basictypes.cpp#L985 Git commit 2a01d5346b7c118111105654fe560b049af64b77 by Oliver Kellogg. Committed on 11/01/2020 at 13:07. Pushed by okellogg into branch 'release/19.12'. Followup to commit 0459a73 addresses comment #2 : umbrello/basictypes.cpp - In function toExtensions() handle all enum values. umbrello/codeimpwizard/codeimpselectpage.cpp - In function changeLanguage() use function Uml::ProgrammingLanguage::toExtensions(). M +43 -12 umbrello/basictypes.cpp M +1 -62 umbrello/codeimpwizard/codeimpselectpage.cpp https://invent.kde.org/kde/umbrello/commit/2a01d5346b7c118111105654fe560b049af64b77 (In reply to Ralf Habacker from comment #2) > Just an info - you fixed the extensions in > https://invent.kde.org/kde/umbrello/blob/ > 0459a7368321d69b8cb567142ad82601477575c1/umbrello/codeimpwizard/ > codeimpselectpage.cpp#L332, which are a duplicate of > Uml::ProgrammingLanguage::toExtensions(Enum item), see > https://invent.kde.org/kde/umbrello/blob/ > 0459a7368321d69b8cb567142ad82601477575c1/umbrello/basictypes.cpp#L985 Many thanks for noticing. |