Bug 374095

Summary: QOffscreenSurface created off the main/gui thread
Product: [Applications] kdenlive Reporter: RJVB <rjvbertin>
Component: Rendering & ExportAssignee: Jean-Baptiste Mardelle <jb>
Status: RESOLVED WORKSFORME    
Severity: normal CC: fritzibaby
Priority: NOR    
Version First Reported In: 17.04.0   
Target Milestone: ---   
Platform: Compiled Sources   
OS: macOS   
Latest Commit: https://commits.kde.org/kdenlive/6675c4a509046aa3b57c60cbc3f31435e09c2df7 Version Fixed/Implemented In:
Sentry Crash Report:

Description RJVB 2016-12-23 18:28:29 UTC 
Since v 16.8.x I'm seeing startup warnings/errors on the calling terminal, under OS X:

```
Attempting to create QWindow-based QOffscreenSurface outside the gui thread. Expect failures.
2016-12-23 19:13:17.058 kdenlive[1807:e103] invalid drawable
Attempting to create QWindow-based QOffscreenSurface outside the gui thread. Expect failures.
2016-12-23 19:13:17.071 kdenlive[1807:e103] invalid drawable
2016-12-23 19:13:43.139 kdenlive[1807:e103] invalid drawable
2016-12-23 19:13:43.281 kdenlive[1807:e103] invalid drawable
```

The "invalid drawable" messages also appear in the System.log indicating that they were made with `NSLog()`, presumably by Qt.

I haven't investigated this yet because I didn't notice any feature loss or issues, but it's probably worth raising the issue. Doing OpenGL graphics off the main thread used to be a sure recipe for Mac KPs, and Qt still doesn't work properly when the event loop isn't handled on the main thread.
Comment 1 Jean-Baptiste Mardelle 2016-12-23 22:42:43 UTC 
Thanks for your report. In fact the same warning displays on the windows version and I also think we should take care of this
Comment 2 Jean-Baptiste Mardelle 2016-12-28 14:29:15 UTC 
Git commit 6675c4a509046aa3b57c60cbc3f31435e09c2df7 by Jean-Baptiste Mardelle.
Committed on 28/12/2016 at 14:29.
Pushed by mardelle into branch 'Applications/16.12'.

Fix warning about QOffscreenSurface thread

M  +7    -3    src/monitor/glwidget.cpp
M  +1    -0    src/monitor/glwidget.h

https://commits.kde.org/kdenlive/6675c4a509046aa3b57c60cbc3f31435e09c2df7
Comment 3 RJVB 2017-04-30 17:01:56 UTC 
Fix wasn't sufficient or was dropped. In v17.04.0:

Attempting to create QWindow-based QOffscreenSurface outside the gui thread. Expect failures.
2017-04-30 18:56:33.443 kdenlive[277:df03] invalid drawable
Attempting to create QWindow-based QOffscreenSurface outside the gui thread. Expect failures.
2017-04-30 18:56:33.453 kdenlive[277:df03] invalid drawable
2017-04-30 18:57:14.689 kdenlive[277:df03] invalid drawable
2017-04-30 18:57:14.768 kdenlive[277:df03] invalid drawable
Comment 4 emohr 2018-11-10 17:30:30 UTC 
Please try with the actual Kdenlive AppImage version 18.08.3
Comment 5 Bug Janitor Service 2018-11-25 04:45:57 UTC 
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 6 Bug Janitor Service 2018-12-10 03:44:22 UTC 
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!