Bug 374021

Summary:	Krita 3.1 Crop tool - Tool Options - Ratio Up/Down buttons changes value by 1.0 per step. Too large
Product:	[Applications] krita	Reporter:	Tyson Tan <tysontanx>
Component:	Dockers	Assignee:	Krita Bugs <krita-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	halla
Priority:	NOR
Version:	3.1.0
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://commits.kde.org/krita/255bcb5930302597b8655ad36bc206f26bf5856b	Version Fixed In:

Description Tyson Tan 2016-12-22 02:39:29 UTC

In Krita 3.1, Crop tool - Tool Options - Ratio Up/Down buttons changes value by 1.0 per step. This is just too large. Those buttons are there to do small tweaks. But now one click you go from square to noodle, making them useless in most situations. They should change the value by 0.01 per step, like it was before.

Comment 1 Halla Rempt 2016-12-22 08:23:09 UTC

Hm, that's been the case since 3.0, it seems, so it's not dependent on Jospin's calculating spinboxes patch.

Comment 2 Halla Rempt 2016-12-22 08:26:35 UTC

Git commit 64a4c9e32a012f72708c543ee96e2ca6076357c1 by Boudewijn Rempt.
Committed on 22/12/2016 at 08:25.
Pushed by rempt into branch 'master'.
Related: bug 0, bug 1

As it was in 2.9; the change to 1.0 probably wasn't intentional,
but caused by not changing Qt's default value.

M  +3    -0    plugins/tools/tool_crop/wdg_tool_crop.ui

https://commits.kde.org/krita/64a4c9e32a012f72708c543ee96e2ca6076357c1

Comment 3 Halla Rempt 2016-12-22 08:26:55 UTC

Git commit 255bcb5930302597b8655ad36bc206f26bf5856b by Boudewijn Rempt.
Committed on 22/12/2016 at 08:26.
Pushed by rempt into branch 'krita/3.1'.
Related: bug 0, bug 1

As it was in 2.9; the change to 1.0 probably wasn't intentional,
but caused by not changing Qt's default value.

M  +3    -0    plugins/tools/tool_crop/wdg_tool_crop.ui

https://commits.kde.org/krita/255bcb5930302597b8655ad36bc206f26bf5856b

Comment 4 Tyson Tan 2016-12-22 08:58:25 UTC

Thank you Boud! 

P.S. I'm sure this never happened before Krita 3.1.0 final, though. I use this function all the time, cropping photos into certain ratio. Can it be some changes in Qt that you used to compile the appimage builds?

Comment 5 Halla Rempt 2016-12-22 09:12:49 UTC

Hm... No, that's not likely. I tested with the 3.0 appimage and there the step is also 1; it probably changed in March, in 

commit e05682dafed2a822ea1a85e9cd472eb70f525b72
Author: Scott Petrovic <spetrovic@swankmp.com>
Date:   Fri Mar 11 11:57:13 2016 -0600

    crop tool options UI improvements to make it easier to understand