Summary: | [Crash] Krita crashed when using gradient on a selection. | ||
---|---|---|---|
Product: | [Applications] krita | Reporter: | Raghavendra kamath <raghu> |
Component: | General | Assignee: | Krita Bugs <krita-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | crash | CC: | halla |
Priority: | NOR | Keywords: | drkonqi |
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/krita/3e53dbf915a6799160090be3cc5594d29473514a | Version Fixed In: |
Description
Raghavendra kamath
2016-12-19 10:17:55 UTC
Hm... Where it crashes is in the color picker mode of the paint tool. This might be one for Dmitry, because I am lost here. Asserts exist to be confirmed... Git commit ebfaab84a240efe7b9ba42e65ecdd346e0737007 by Dmitry Kazakov. Committed on 12/01/2017 at 11:03. Pushed by dkazakov into branch 'krita/3.1'. Temporary workaround for color picker bug in the gradient tool The proper fix would be to stop the action in KisShortcutMatcher when the tool switches. It would really fix the bug. Ref T4962 M +11 -1 libs/ui/tool/kis_tool_paint.cc https://commits.kde.org/krita/ebfaab84a240efe7b9ba42e65ecdd346e0737007 I had to revert that commit; it broke shift-drag brush resizing. Git commit ca1e6b45afd8d648deeec94257d0311d921ea0c0 by Dmitry Kazakov. Committed on 27/03/2017 at 10:56. Pushed by dkazakov into branch 'kazakov/svg-loading'. Fix a crash after switching tools while running color picking The input manager should finish the action before the tool is switched, otherwise the tool may be left with dangling KoStrokeId pointers and crash after the next execution. Fixes T4962 M +2 -0 libs/flake/KoToolManager.cpp M +6 -0 libs/flake/KoToolManager.h M +10 -0 libs/ui/input/kis_input_manager.cpp M +1 -0 libs/ui/input/kis_input_manager.h https://commits.kde.org/krita/ca1e6b45afd8d648deeec94257d0311d921ea0c0 Git commit daa136675d54877780bd136225e77e611347c223 by Dmitry Kazakov. Committed on 29/03/2017 at 10:03. Pushed by dkazakov into branch 'krita/3.1'. Fix a crash after switching tools while running color picking The input manager should finish the action before the tool is switched, otherwise the tool may be left with dangling KoStrokeId pointers and crash after the next execution. Fixes T4962 M +2 -0 libs/flake/KoToolManager.cpp M +6 -0 libs/flake/KoToolManager.h M +10 -0 libs/ui/input/kis_input_manager.cpp M +1 -0 libs/ui/input/kis_input_manager.h https://commits.kde.org/krita/daa136675d54877780bd136225e77e611347c223 Git commit 3e53dbf915a6799160090be3cc5594d29473514a by Boudewijn Rempt. Committed on 08/06/2017 at 07:49. Pushed by rempt into branch 'krita/3.2'. Revert "Fix a crash after switching tools while running color picking" This reverts commit daa136675d54877780bd136225e77e611347c223. Related: bug 380955 This commit caused an infinite loop when creating a new shape by clicking in the add-shape docker and then dragging an outline. CCMAIL:dimula73@gmail.com Date: Mon Mar 27 13:56:39 2017 +0300 Fix a crash after switching tools while running color picking The input manager should finish the action before the tool is switched, otherwise the tool may be left with dangling KoStrokeId pointers and crash after the next execution. Fixes T4962 I'm not sure how to fix both issues; reverting for now. M +0 -1 libs/flake/KoToolManager.cpp M +0 -6 libs/flake/KoToolManager.h M +0 -10 libs/ui/input/kis_input_manager.cpp M +0 -1 libs/ui/input/kis_input_manager.h https://commits.kde.org/krita/3e53dbf915a6799160090be3cc5594d29473514a Git commit 3e53dbf915a6799160090be3cc5594d29473514a by Boudewijn Rempt. Committed on 08/06/2017 at 07:49. Pushed by rempt into branch 'krita/3.2'. Revert "Fix a crash after switching tools while running color picking" This reverts commit daa136675d54877780bd136225e77e611347c223. Related: bug 380955 This commit caused an infinite loop when creating a new shape by clicking in the add-shape docker and then dragging an outline. CCMAIL:dimula73@gmail.com Date: Mon Mar 27 13:56:39 2017 +0300 Fix a crash after switching tools while running color picking The input manager should finish the action before the tool is switched, otherwise the tool may be left with dangling KoStrokeId pointers and crash after the next execution. Fixes T4962 I'm not sure how to fix both issues; reverting for now. M +0 -1 libs/flake/KoToolManager.cpp M +0 -6 libs/flake/KoToolManager.h M +0 -10 libs/ui/input/kis_input_manager.cpp M +0 -1 libs/ui/input/kis_input_manager.h https://commits.kde.org/krita/3e53dbf915a6799160090be3cc5594d29473514a |