| Summary: | Cannot create a new stamp brush if the brush editor shows the no-brush selected icon | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | David REVOY <info> |
| Component: | Brush engines | Assignee: | vanyossi <ghevan> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | freebox64, halla, landchuckz, scottpetrovic |
| Priority: | NOR | ||
| Version: | 3.1.1 | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/krita/c5dd867fa2a043459a86162021d3cc3f14bc041e | Version Fixed In: | |
| Sentry Crash Report: | |||
|
Description
David REVOY
2016-12-18 17:09:13 UTC
Hi David, I can reproduce what you described in Krita 3.1.1 too. (The '+Stamp' button doesn't take the selected area on canvas while the 'Clipboard' workaround, well, it works). (Krita 3.1.1 appimage btw, on Ubuntu 14.04). Confirming. This was already broken in 3.0. It only happens if you haven't selected another preset after creating a new image. Git commit 65caf8179bb0733faf401eaa5b39a78876f1ef5f by Boudewijn Rempt. Committed on 22/12/2016 at 11:25. Pushed by rempt into branch 'master'. If you'd create an image, and then without changing brush preset would try to use that image as a new stamp, it would fail because the preset editor was initialized before the image was added to to the viewmanager. M +29 -26 libs/ui/KisViewManager.cpp https://commits.kde.org/krita/65caf8179bb0733faf401eaa5b39a78876f1ef5f Git commit c5dd867fa2a043459a86162021d3cc3f14bc041e by Boudewijn Rempt. Committed on 22/12/2016 at 11:26. Pushed by rempt into branch 'krita/3.1'. If you'd create an image, and then without changing brush preset would try to use that image as a new stamp, it would fail because the preset editor was initialized before the image was added to to the viewmanager. M +28 -25 libs/ui/KisViewManager.cpp https://commits.kde.org/krita/c5dd867fa2a043459a86162021d3cc3f14bc041e Hi, It's impossible to open a document, go to brush-editor, and click on 'stamp' to make an animated brush out of this document : the result will always be an empty preview in the stamp dialog. The 'Stamp' button will works (tested in Krita 3.1.2appimage) only after cliking on a brush preset in the brush docker first. So, I'm reopening this bug-report. I did a fix a bit ago that should solve David's last comment. I didn't see this ticket to link to it. I am on master now and can do the following: 1. Start Krita and open a document 2. go to the brush editor and go to the predefined brush tip area 3. select "+ stamp" option The image preview now appears with the entire image (since there is no selection). *** Bug 379015 has been marked as a duplicate of this bug. *** David reports that this no longer happens. I tested in 4.2.1 with positive results marking as fixed. |