Summary: | Assertion failure with "View Diff" | ||
---|---|---|---|
Product: | [Developer tools] kdevplatform | Reporter: | Francis Herne <mail> |
Component: | git | Assignee: | kdevelop-bugs-null |
Status: | RESOLVED FIXED | ||
Severity: | crash | CC: | kossebau |
Priority: | NOR | ||
Version: | git master | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/kdevplatform/58ef793180cd1cc4b071072fdf2d85e4fb9ea52a | Version Fixed In: | 5.1.0 |
Description
Francis Herne
2016-12-17 14:07:55 UTC
*** Bug 373790 has been marked as a duplicate of this bug. *** Git commit 58ef793180cd1cc4b071072fdf2d85e4fb9ea52a by Francis Herne. Committed on 26/12/2016 at 00:54. Pushed by flherne into branch 'master'. Don't hit assertion with "View Diff" Commit 0c9ff4de caused KDevelop to crash on "View Diff" in almost all cases, because it didn't check `dstRevision.revisionType() == VcsRevision::Special` before calling `dstRevision.specialType()`. I have other doubts about that commit, but for now just fix the bug. M +8 -7 plugins/git/gitplugin.cpp https://commits.kde.org/kdevplatform/58ef793180cd1cc4b071072fdf2d85e4fb9ea52a |