Bug 373713

Summary:	[PATCH] JavaScript Syntax Highlighting broken when using E4X
Product:	[Frameworks and Libraries] frameworks-syntax-highlighting	Reporter:	Andreas Schwier <andreas.schwier>
Component:	syntax	Assignee:	KWrite Developers <kwrite-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://commits.kde.org/syntax-highlighting/11a804b4f5bb347ddb1d06bfa21a6d2eaff0183a	Version Fixed/Implemented In:	5.37
Sentry Crash Report:

Description Andreas Schwier 2016-12-16 09:09:32 UTC

E4X allows embedding XML fragments in JavaScript files. We use that extensively in the OpenSCDP project, which is based on the Rhino JavaScript engine.

Unfortunately JS syntax highlighting for regular expressions is triggered at xml tags in the source code.

E.g. "var p = <p>Hello World</p>"

would trigger context "(regex caret first check)" at the </p> tag.

The suggested fix is to add

<Detect2Chars attribute="Normal Text" context="NoRegExp" char="&lt;" char1="/" />
<Detect2Chars attribute="Normal Text" context="NoRegExp" char="/" char1="&gt;" />

before

<DetectChar attribute="Regular Expression" context="(regex caret first check)" char="/" />

in javascript.xml syntax file

Comment 1 Dominik Haumann 2016-12-25 13:54:54 UTC

Reading about E4X, it seems that it is an extension to JavaScript, so not officially part of the ECMAScript standard, so adding this would be kind of non-compliant.

As I understand ActionScript 3.0 does support E4X by default. However, we only ship a ActionScript 2.0 highlighting, so that does not really solve the issue. However, ActionScript does highlight this particular case correctly. Not sure, whether it could be a solution for you.

Adding this patch would solve the issue for this particular case. I would be fine with that, but if it turns out it's a problem in other cases, I would revert this change.

Opinions?

Comment 2 Andreas Schwier 2017-01-02 11:21:16 UTC

That's fine with me.

Comment 3 Dominik Haumann 2017-07-21 17:33:14 UTC

Git commit 11a804b4f5bb347ddb1d06bfa21a6d2eaff0183a by Dominik Haumann.
Committed on 21/07/2017 at 17:32.
Pushed by dhaumann into branch 'master'.

JavaScript Highlighting: Add support for E4X xml extension

Thanks to Andreas Schwier for the patch.
FIXED-IN: 5.37

M  +5    -0    autotests/folding/highlight.js.fold
M  +5    -0    autotests/html/highlight.js.html
M  +5    -0    autotests/input/highlight.js
M  +5    -0    autotests/reference/highlight.js.ref
M  +4    -1    data/syntax/javascript.xml

https://commits.kde.org/syntax-highlighting/11a804b4f5bb347ddb1d06bfa21a6d2eaff0183a