Bug 373655

Summary: Input Actions daemon checkbox in Custom Shortcuts kcm doesn't reflect actual configuration
Product: [Applications] systemsettings Reporter: Michal Ziabkowski <mziab>
Component: kcm_khotkeysAssignee: Michael Jansen <kde>
Status: RESOLVED UNMAINTAINED    
Severity: normal    
Priority: NOR    
Version First Reported In: 5.20.3   
Target Milestone: ---   
Platform: Gentoo Packages   
OS: Linux   
See Also: https://bugs.kde.org/show_bug.cgi?id=365091
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: Use !settings->isDaemonDisabled() to set the daemon checkbox

Description Michal Ziabkowski 2016-12-14 19:19:11 UTC
Created attachment 102783 [details]
Use !settings->isDaemonDisabled() to set the daemon checkbox

While input actions work just fine, it seems the "Start the Input Actions daemon on login" checkbox doesn't reflect the actual configuration. My khotkeysrc has Disabled=false in [Main]. However, in the gui the option appears as the daemon is disabled, i.e. the checkbox is unchecked.

Further investigation shows the config is loaded properly, it's never used in GlobalSettingsWidget::doCopyFromObject, which instead does:
ui.enabled->setChecked(file.readEntry("X-KDE-Kded-autoload", false));
At least on my install this always returns false, since the .desktop doesn't have this key.

Enclosed please find a quick fix, which uses !settings->isDaemonDisabled() to set the checkbox. I'm unsure, however, if that's the proper fix.

Here are some system specs:
kde-frameworks 5.29.0
Qt 5.6.2
xcb platform
Comment 1 Christoph Feck 2016-12-20 19:57:50 UTC
Hm, in the function below, doCopyToObject() writes this key to the desktop file, so I am not sure either if your approach is correct.

Thanks for the investigation. I suggest to create a review request for group 'plasma' at https://git.reviewboard.kde.org/
Comment 2 Michal Ziabkowski 2016-12-28 13:59:17 UTC
I'm hesitant to do that, since this is probably not the proper fix, just a quick workaround. It would be nice if someone with a deeper insight could look into the actual cause of the problem.
Comment 3 Nate Graham 2024-03-04 19:42:05 UTC
As announced in https://pointieststick.com/2023/07/26/what-we-plan-to-remove-in-plasma-6/ and https://community.kde.org/Plasma/Plasma_6#Removals, I'm afraid KHotKeys has reached end-of-life in Plasma 6. Accordingly, all bug reports and feature requests for it must be closed now.

Most of what KHotKeys could do can already be done with the newer KGlobalAccel system in Plasma 6. A few features such as mouse gestures and triggering conditions based on changes to window states are not yet implemented in the new system. These will be added in the future if and when resources materialize for them, and/or when a kind soul submits patches to implement them! :) Meanwhile, the 3rd-party "Mouse Actions" app (https://github.com/jersou/mouse-actions) may be usable for implementing your own mouse gestures again.

Thanks for your understanding, everyone.