Bug 373618

Summary:	Instant recording not working in kaffeine 2.0.5
Product:	[Applications] kaffeine	Reporter:	yulinux
Component:	general	Assignee:	Mauro Carvalho Chehab <mchehab>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description yulinux 2016-12-13 16:28:57 UTC

Hello all, 

I use kaffeine 2.0.5 (Fedora Package, RPM fusion) and the instant recording function does not work any more. I searched a bit and found a similar bug (364017 [1]) which was fixed in 2.0.5, see [2]. I checked out kaffeine git and added recording.disabled = false; to the void DvbTab::instantRecord(bool checked) function in dvbtab.cpp similar to the patch from above and compiled kaffeine. Now it seems to work.

If this makes sense (I have only very limited programming knowledge), this would be nice to have out of the box. Actually I do not really understand the concept of the "disabled" parameter, as it can not be set by the GUI (but is displayed in the "recording schedule" window).

Interesting: With 2.0.5 the instant record function worked when using the shortcut, but not when clicked via GUI.

Thank you


[1] https://bugs.kde.org/show_bug.cgi?id=364017
[2] https://cgit.kde.org/kaffeine.git/commit/?id=7f9541f9a6749247eaac4079ba41be60e7284d85

Comment 1 Mauro Carvalho Chehab 2016-12-28 19:55:13 UTC

(In reply to yulinux from comment #0)

> I use kaffeine 2.0.5 (Fedora Package, RPM fusion) and the instant recording
> function does not work any more. I searched a bit and found a similar bug
> (364017 [1]) which was fixed in 2.0.5, see [2]. I checked out kaffeine git
> and added recording.disabled = false; to the void DvbTab::instantRecord(bool
> checked) function in dvbtab.cpp similar to the patch from above and compiled
> kaffeine. Now it seems to work.
> 
> If this makes sense (I have only very limited programming knowledge), this
> would be nice to have out of the box. 

Just added a commit that should solve it. Please test:

    https://cgit.kde.org/kaffeine.git/commit?id=f541dcd64b74beb07430c18e03f8cbf92366227f

> Actually I do not really understand
> the concept of the "disabled" parameter, as it can not be set by the GUI
> (but is displayed in the "recording schedule" window).

I suspect that this was added to indicate when a program record was disabled because it conflicts with some other record.

Comment 2 yulinux 2016-12-30 17:36:52 UTC

Yes it is fixed! 

Great, thank you.