Summary: | Inconsistent items selected count with groups in the main view [patch] | ||
---|---|---|---|
Product: | [Applications] digikam | Reporter: | Simon <freisim93> |
Component: | Albums-ItemGroup | Assignee: | Digikam Developers <digikam-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | caulier.gilles |
Priority: | NOR | ||
Version: | 5.3.0 | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/digikam/830f70e8ace3990520f114e65300d1c5b6cb3a1c | Version Fixed In: | 5.4.0 |
Attachments: | Fixes image counts for grouped images |
Description
Simon
2016-12-12 09:37:48 UTC
Created attachment 102892 [details] Fixes image counts for grouped images The attached patch should solves the described problem. It is related to https://bugs.kde.org/show_bug.cgi?id=372027 as it takes care of grouping when all items are requested (the referenced issue did this for selected items). In addition there was a bug in TableView::selectedImageInfos() where the currentIndex is compared to a list of row indexes. The currentIndex however always had column!=0, so they never matched. This caused the wrong selected image count (base offset of 1 or 2). The patch sound acceptable as it's not too intrusive. Gilles Caulier Git commit 830f70e8ace3990520f114e65300d1c5b6cb3a1c by Maik Qualmann. Committed on 20/12/2016 at 20:44. Pushed by mqualmann into branch 'master'. apply patch #102892 from Simon to fix image counts for grouped images and polish FIXED-IN: 5.4.0 M +2 -1 NEWS M +15 -10 app/items/imagecategorizedview.cpp M +3 -2 app/items/imagecategorizedview.h M +2 -2 app/views/tableview/tableview.cpp M +6 -4 app/views/tableview/tableview_model.cpp https://commits.kde.org/digikam/830f70e8ace3990520f114e65300d1c5b6cb3a1c |