Bug 373440

Just got 16.12.0 and this is still happening.

Confirmed with konsole 16.12.0 on Arch Linux.

Possibly related issue: previously a tab could be dragged between windows. Now it will only allow rearrangement within one window, or creation of a new window.

Hi I am Chirath R, I would like to work on this bug.
Could someone tell me how the function 'shouldUseNewProcess()' on line number 184 in main.cpp is called?
It has to return false when the "konsole --new-tab" is executed. I tried using a qWarning() to see if it's executed, but it doesn't seem to be called.

Still happens in konsole 16.12.1

Git commit cd61ee84d86a17059cf55d54d364b61519bd080e by Kurt Hindenburg.
Committed on 22/01/2017 at 18:25.
Pushed by hindenburg into branch 'master'.

Add comment that topLevelWidets() returns no windows

M  +1    -0    src/Application.cpp

https://commits.kde.org/konsole/cd61ee84d86a17059cf55d54d364b61519bd080e

The issue is porting away from KUniqueApplication I guess. So the new process does not see the windows of the existing process.

Can't reproduce it here with git master of konsole and qt 5.8, "konsole --new-tab" opens a tab in the window I'm in.

My bad, it happens when you turn off running all konsole's in the same process. I recently committed a change that defaulted to running them in separate processes for crash safety. You can change it back in settings -> configure konsole.

https://git.reviewboard.kde.org/r/129886/

I can verify that enabling "Run all Konsole windows in a single process" and restarting konsole allows for "konsole --new-tab" to work in konsole 16.12.1 and qt 5.8

I can verify that enabling "Run all Konsole windows in a single process" and restarting konsole allows for "konsole --new-tab" to work in konsole 16.12.1 and qt 5.8

Git commit cbb7448434840d432ae80627d559ef4367daadfd by Martin T. H. Sandsmark.
Committed on 27/01/2017 at 17:13.
Pushed by sandsmark into branch 'master'.

Fix opening of new tabs with multiple processes

Make sure we re-use the process if the user wants a new tab.
REVIEW: 129886

M  +0    -1    src/Application.cpp
M  +2    -2    src/main.cpp

https://commits.kde.org/konsole/cbb7448434840d432ae80627d559ef4367daadfd

I just noticed today that enabling "Run all Konsole windows in a single process" and trying to run a "konsole --new-tab -e ssh HOST" doesn't work but it does work without that setting but it pops in a new window.
Is this related to this bug? Will the change fix that?
Should it be a new bug?

*** Bug 376067 has been marked as a duplicate of this bug. ***

(In reply to Cade Robinson from comment #13)
> I just noticed today that enabling "Run all Konsole windows in a single
> process" and trying to run a "konsole --new-tab -e ssh HOST" doesn't work

Works fine here.

Maybe related to bug#366793 somehow? (because of the -e option)
I am using konsole 16.12.1 with the fix for that.

On a side-note: try adding --hold as well. If there's an error, the new tab will close immediately otherwise and you may not even see it appearing at all. That happens with a new window, but in this case it's more visible.

Using --hold I get errors like this:
running a ssh root@server:
ssh: Could not resolve hostname konsole: Name or service not known

running uname:
/usr/bin/uname: extra operand 'konsole'
Try '/usr/bin/uname --help' for more information.

running "echo $0":
konsole


Running those commands without "--new-tab" run fine but pop up a new window obviously.

Still happening in konsole 16.12.2

(In reply to Cade Robinson from comment #16)
> Using --hold I get errors like this:
> running a ssh root@server:
> ssh: Could not resolve hostname konsole: Name or service not known

And what command exactly did you run?
Just to be clear, that is what I meant:
konsole --hold --new-tab -e ssh HOST

(In reply to Cade Robinson from comment #17)
> Still happening in konsole 16.12.2

Both fixes (for the --new-tab and the -e option) are not in 16.12.2.

With the option "Run all Konsole windows in a single process" running these exact commands:
konsole --hold --new-tab -e ssh cadetest
and
konsole --hold --new-tab -e ssh root@cadetest

Will open a new tab BUT:
both give the error in the new tab:
ssh: Could not resolve hostname konsole: Name or service not known

Also the tab name is "() konsole"

The server cadetest exists and I can ssh to it normally.

If I disable "Run all Konsole windows in a single process" and run:
konsole --hold --new-tab -e ssh cadetest

It will open a new window and ssh to cadetest server normally BUT not be a new tab.

to clarify comment 16 when I say "running uname" and running echo I mean as the -e param

konsole --hold --new-tab -e uname
and
konsole --hold --new-tab -e 'echo $0'

I think I was able to compile konsole 16.12.2 via the arch ABS system with the new tab patch and the -e patch.
Assuming I did it correctly the new tab patch still opens a new window unless you have "Run all Konsole windows in a single process" checked. So not sure that is fixed?

With "Run all Konsole windows in a single process" checked and running
konsole --hold --new-tab -e ssh cadetest
will open a new tab and will run the command passed in -e

(In reply to Cade Robinson from comment #21)
> I think I was able to compile konsole 16.12.2 via the arch ABS system with
> the new tab patch and the -e patch.
> Assuming I did it correctly the new tab patch still opens a new window
> unless you have "Run all Konsole windows in a single process" checked. So
> not sure that is fixed?

I haven't tried the "new tab" patch from comment#12 yet, so I cannot tell if it is working or not.

I will do so in the next days and report back then.

> With "Run all Konsole windows in a single process" checked and running
> konsole --hold --new-tab -e ssh cadetest
> will open a new tab and will run the command passed in -e

Ok, so the "new" problem you mentioned in comment#13 was indeed (a side effect of) bug#366793.
Strange that it didn't happen without --new-tab, but well...
We can ignore that now then, I suppose. ;-)

I can confirm that the fix doesn't work.
The --new-tab option still opens a new window if "Run all Konsole windows in a single process" is disabled.

I tried the patch on top of 16.12.2 and also tried with the latest source from git master.

I made an interesting observation (I think):
"konsole --new-tab" only opens a new window when the existing one has been started "normally".

If you run "konsole --new-tab" again (or start the first konsole with "--new-tab" already), it will indeed open a new tab as expected (with the fix from comment#12 that is, without it it will still open a new window).

OTOH, maybe it would be a good idea to revert the change to use separate processes or at least enable "Run all Konsole windows in a single process" by default until the problems are fixed?
(dragging and dropping tabs between windows doesn't work either with separate processes)
Just wondering...

My personal opinion is that the potential data loss that can result from a single konsole window crashing and taking all the other instances with it is a bigger problem than --new-tab not working.

Anyhow, it seems like this is an issue with KDBusService. It doesn't notice the existing Konsole process if that one was launched with KDBusService::Multiple. We could do like Okular and implement the single application functionality ourselves, or do the same as Okular in KDBusService. I'm not sure what is appropriate for KDBusService.

(In reply to Martin Sandsmark from comment #25)
> My personal opinion is that the potential data loss that can result from a
> single konsole window crashing and taking all the other instances with it is
> a bigger problem than --new-tab not working.
Ok, fair enough.
I was just thinking out loud.

Hi,

I just upgraded to kubuntu zesty with konsole 16.12.3 and am experiencing the same problems, i.e.:

- with "Run all Konsole windows in a single process" disabled, a new window opens

- with "Run all Konsole windows in a single process" enabled, a new tab is opened, but I can't use the -e option.

In general, it seems to me is that when issuing the command 

konsole --hold --new-tab -e 'cmd args'

konsole opens a new tab and in it tries to run 'cmd konsole' instead of 'cmd args', therefore the 'cmd' fails because it doesn't recognise 'konsole' as an argument.

This makes konsole unusable to me, as I mostly use it with the '-e ssh host' option.

(In reply to kde.bugs from comment #27)
> - with "Run all Konsole windows in a single process" enabled, a new tab is
> opened, but I can't use the -e option.
> 
> In general, it seems to me is that when issuing the command 
> 
> konsole --hold --new-tab -e 'cmd args'
> 
> konsole opens a new tab and in it tries to run 'cmd konsole' instead of 'cmd
> args', therefore the 'cmd' fails because it doesn't recognise 'konsole' as
> an argument.

Again, this is fixed in 17.04, by the fix for bug#366793.
And it's totally unrelated to *this* bug report anyway IMHO.

(In reply to Wolfgang Bauer from comment #28)
> Again, this is fixed in 17.04, by the fix for bug#366793.
> And it's totally unrelated to *this* bug report anyway IMHO.

Thanks for a quick reply. Apologies in advance if I get something wrong, I am "just a user". I wasn't aware of bug#366793, I can now see how it may be unrelated to *this* bug report. Just to be sure, you are referring to a fix in 17.04 of konsole, so that users like me of kubuntu 17.04 (unfortunate coincidence in versions...) are stuck with konsole 16.12.3 that still carries the "-e" bug. In other words, I need to address the kubuntu development if I want to see this fixed in my distribution?

As for *this* "--new-tab" bug, no solution yet? Or does the commit in comment #12 fix it and this is captured in a konsose version greater than 16.12.3, so that again I should address the kubuntu development team? Sorry, not clear to me how to work out in what version of konsole a specific commit has been implemented.

Cheers

(In reply to kde.bugs from comment #29)
In other words, I need to address the kubuntu
> development if I want to see this fixed in my distribution?

Correct.
There won't be any further 16.12.x releases, and even if they wouldn't turn up automatically in your distribution.

Your distribution would either need to backport the fix to their package, or upgrade the package to the latest version where it is fixed.

> As for *this* "--new-tab" bug, no solution yet?

No. The commit in comment 12 was supposed to fix it, but as it turned out it does not really (that's why this bug report was REOPENED).

It can be "workarounded" by enabling the option "Run all Konsole windows in a single process" though, that was konsole's (only supported) behavior before 16.12.
Of course that will unfortunately trigger bug#366793 in 16.12 as you noticed...

Hi! On my Arch linux machine, since updating to Konsole 17.04.0, the --new-tab switch started to work just fine regardless of "Run all Konsole windows in a single process" option. Thanks a lot for fixing it!

Maybe it could also be related to Qt version since it is misbehaving on Kubuntu? I don't know. Anyway I have:
Konsole 17.04.0
Qt 5.8.0
KF 5.33

OK, I've now replicated the behaviour as well. Sorry about the previous comment. 

When Konsole is started without --new-tab parameter, then subsequent "konsole --new-tab" opens a new window. Workaround is indeed checking "Run all Konsole windows in a single process".

If I start first konsole process with --new-tab. The next --new-tab starts append a new tab as expected. No need for the workaround.

I can reproduce this bug as well.

I don't think this is expected behavior, is it?
Has anyone an idea what could be done to fix this issue?


System Information:
konsole 17.12.3
kde-plasma-version: 5.12.6
kde-frameworks-version: 5.44.0
qt-version: 5.9.5

(In reply to Sebastian from comment #33)
> I don't think this is expected behavior, is it?
> Has anyone an idea what could be done to fix this issue?

See comment#24 and comment#25.

Can someone please test and confirm if this issue is still occurring or if this bug report can be marked as resolved. I'm setting status to "needsinfo" pending your response, please change back to "reported" or "resolved" when you respond, thanks.

(In reply to Justin Zobel from comment #35)
> Can someone please test and confirm if this issue is still occurring or if
> this bug report can be marked as resolved. I'm setting status to "needsinfo"
> pending your response, please change back to "reported" or "resolved" when
> you respond, thanks.

Yes, it still happens in 20.08.3.

Although the behavior slightly changed over time, it seems.
- "konsole --new-tab" also opens a new window now if the konsole was already run with --new-tab
- with "Run all Konsole windows in a single process" enabled, it opens a new tab if the konsole was already run with --new-tab, otherwise it opens a new window

(In reply to Wolfgang Bauer from comment #36)
> (In reply to Justin Zobel from comment #35)
> > Can someone please test and confirm if this issue is still occurring or if
> > this bug report can be marked as resolved. I'm setting status to "needsinfo"
> > pending your response, please change back to "reported" or "resolved" when
> > you respond, thanks.
> 
> Yes, it still happens in 20.08.3.
> 
> Although the behavior slightly changed over time, it seems.
> - "konsole --new-tab" also opens a new window now if the konsole was already
> run with --new-tab
> - with "Run all Konsole windows in a single process" enabled, it opens a new
> tab if the konsole was already run with --new-tab, otherwise it opens a new
> window

There are probably other factors that come into play here too; when I tried again now with "Run all Konsole windows in a single process" enabled, it always opened a new tab as it should, also the first time in a standard konsole run without --new-tab.

With "Run all Konsole windows in a single process" disabled (the default), it doesn't work at all anymore though AFAICT.

(In reply to Justin Zobel from comment #35)
> Can someone please test and confirm if this issue is still occurring or if
> this bug report can be marked as resolved. I'm setting status to "needsinfo"
> pending your response, please change back to "reported" or "resolved" when
> you respond, thanks.

I can even say that at my level there is regression since when going from version 20.04.3 to 20.08.3 under gentoo, the bug reappeared.
I have to check the box "Run all konsole windows in a single process" so that the problem does not arise.

(In reply to Justin Zobel from comment #35)
> Can someone please test and confirm if this issue is still occurring or if
> this bug report can be marked as resolved. I'm setting status to "needsinfo"
> pending your response, please change back to "reported" or "resolved" when
> you respond, thanks.

I just updated to 20.08.3 on Fedora 32 and can confirm the same behaviour as noted by two previous comments. The only workaround now is to enable "Run all konsole windows in a single process", without it --new-tab doesn't work at all for me.

*** Bug 410584 has been marked as a duplicate of this bug. ***

you can't use --new-tab if you launch from a terminal, since it can't reuse the existing process from a new tty, I assume that is what you're seeing:

https://invent.kde.org/utilities/konsole/-/blob/master/src/main.cpp#L225-297

If so the behavior is expected.

If anyone has any idea on how to fix the issues there when re-using the existing process feel free to comment, but it has been an open problem for a while.

Hello,

I noticed this also when right-clicking Konsole in the taskbar and choosing "Open a new tab". It opens a new window instead of a tab. I am guessing it is the same issue and that the taskbar action is probably just running `konsole --new-tab`. If I turn on "Run all Konsole windows in a single process", which is off by default, then it opens a new tab. I have near 0 experience coding for Qt/Plasma, so I apologize if I am ignorantly over-simplifying the issue here, but could you possibly simplify the "new tab" action and just tell the running process to open a new tab over something like dbus?

Thanks,
Dan

(In reply to Christophe PEREZ from comment #38)
> I can even say that at my level there is regression since when going from
> version 20.04.3 to 20.08.3 under gentoo, the bug reappeared.
> I have to check the box "Run all konsole windows in a single process" so
> that the problem does not arise.

Updating from 20.08.3 to 20.12.3 is worse.
With or without "Run all konsole windows in a single process", --new-tab only creates new window, and never open a new tab.

I am on manjaro XFCE konsole 21.04.3.
In this version if "run all Konsole with single process" checked and first instance started with --new-tab, then another --new-tab works. This is an acceptable workaround. With this combination the dbus address is org.kde.konsole

In other cases

dbus-send --dest=$KONSOLE_DBUS_SERVICE --print-reply=literal --type=method_call /Windows/1 org.kde.konsole.Window.newSession
works.

and also works with --dest=org.kde.konsole-$KPID where $KPID is the pid of the konsole.

Maybe the problem is that the dbus service is not the standard org.kde.konsole

Hello,

I checked this issue and I think it can be divided into 2 parts:

1. The first problem seems to be this line (which ironically says "Don't touch"):

https://invent.kde.org/utilities/konsole/-/blob/fb69c183c672dff1d8e5e95d187622980255827c/src/main.cpp#L146

As it is preventing using a single process if 'multiple' is selected in options.

Removing Konsole::KonsoleSettings::useSingleInstance() should be enough.

2. The second problem is that this is working only if konsole is launched with "--new-tab". If konsole is launched with no arguments, calling "konsole --new-tab" from within will open a new window. If "konsole --new-tab" is launched first, every additional "konsole --new-tab" will open a new tab. I am still not sure why is this happening.

However, there is another thing that I noticed:

A new tab is opened only on the initial konsole. So, if you open a konsole and run --new-tab a few times and open additional konsole, doing "konsole --new-tab" will add a tab to the previous konsole, not the current one.

I guess that it is another issue due to a workaround that is just looking for the first non-nullptr window, but that should be checked on another ticket.

I will update if I find anything regarding the second problem why it is happening.

Hello,

After pulling the latest commits on master, I can confirm that removing 

Konsole::KonsoleSettings::useSingleInstance()

that I mentioned in my previous comment, I can get a new tab inside the same window on the first start. 

Can anyone from the commiters on the "DON'T TOUCH" part of the code:

https://invent.kde.org/utilities/konsole/-/blob/fb69c183c672dff1d8e5e95d187622980255827c/src/main.cpp#L146

confirm the usage as I am not familiar with why is that checked along with the problematic options that enforce to create a new process? 

If the useSingleInstance cannot be deleted, then it would need an additional flag just for the "--new-tab" option that will force a single process, not checking if useSingleInstance is enabled or not.

Hope someone can help with this.

Created attachment 140440 [details]
attachment-14463-0.html

I think that the easiest thing there is to specify a pid for the tab.

--new-tab --parent-pid=

because, for multiple processes, it's impossible to know in *what* process
we want a new tab.

I have an old patch that fixes that, but breaks the multiple instance,
that's the reason martin added the DONT TOUCH part of the code.


On Thu, Jul 29, 2021 at 3:21 PM Igor Grkavac <bugzilla_noreply@kde.org>
wrote:

> https://bugs.kde.org/show_bug.cgi?id=373440
>
> --- Comment #46 from Igor Grkavac <grkavac.igor@gmail.com> ---
> Hello,
>
> After pulling the latest commits on master, I can confirm that removing
>
> Konsole::KonsoleSettings::useSingleInstance()
>
> that I mentioned in my previous comment, I can get a new tab inside the
> same
> window on the first start.
>
> Can anyone from the commiters on the "DON'T TOUCH" part of the code:
>
>
> https://invent.kde.org/utilities/konsole/-/blob/fb69c183c672dff1d8e5e95d187622980255827c/src/main.cpp#L146
>
> confirm the usage as I am not familiar with why is that checked along with
> the
> problematic options that enforce to create a new process?
>
> If the useSingleInstance cannot be deleted, then it would need an
> additional
> flag just for the "--new-tab" option that will force a single process, not
> checking if useSingleInstance is enabled or not.
>
> Hope someone can help with this.
>
> --
> You are receiving this mail because:
> You are the assignee for the bug.

At this point, I wonder if we shouldn't just remove the option.

At the very least we should change the --new-tab cli help message, to say this only works when running Konsole in single process mode.

Git commit 9bfc2f134aa6583508e7d09691fd45d083431687 by Kurt Hindenburg.
Committed on 26/10/2021 at 20:27.
Pushed by hindenburg into branch 'master'.

Add note for --new-tab command line help

M  +2    -1    src/Application.cpp

https://invent.kde.org/utilities/konsole/commit/9bfc2f134aa6583508e7d09691fd45d083431687

*** Bug 463302 has been marked as a duplicate of this bug. ***

 konsole --new-tab opens window instead 
Happens on Kubuntu 23.04 and upgraded from 22.10 to 23.04

The new tab works if you have this set:
Preferences -> General -> Run all instance windows in a single process.

without this, it's not easy to find the current konsole window.

Created attachment 158636 [details]
attachment-1242933-0.html

Hello,

You might want to update your script or info on the location of the single
process location via Konsole.

From the Konsole Terminal:
Settings>Configure Konsole>
Enabled by checking the box for "Run all Konsole windows in a single
process"

I had one more question: my --new-tab is working correctly after
changing the above settings.

The current command "konsole --new-tab --profile Garuda" will make a new
tab and switch profiles.

If I don't want to make a new tab and only change the profile of the
Konsole.

What command / settings would I need to adjust to change the profile
Konsole using the CLI without it loading a new Konsole and only updating
the current Konsole I am in and just switching the profiles?

Using  "konsole --profile Garuda" load a new Konsole window with the single
process enabled.

Thank you.

-Matt

On Tue, May 2, 2023 at 1:08 AM <bugzilla_noreply@kde.org> wrote:

> https://bugs.kde.org/show_bug.cgi?id=373440
>
> tcanabrava@kde.org changed:
>
>            What    |Removed                     |Added
>
> ----------------------------------------------------------------------------
>                  CC|                            |tcanabrava@kde.org
>              Status|REOPENED                    |RESOLVED
>          Resolution|---                         |FIXED
>
> --- Comment #53 from tcanabrava@kde.org ---
> The new tab works if you have this set:
> Preferences -> General -> Run all instance windows in a single process.
>
> without this, it's not easy to find the current konsole window.
>
> --
> You are receiving this mail because:
> You are on the CC list for the bug.