| Summary: | Plastik decoration hides buttons when a window is shaded | ||
|---|---|---|---|
| Product: | [Plasma] kwin | Reporter: | Alex <allo> |
| Component: | aurorae | Assignee: | KWin default assignee <kwin-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | kailed, tsujan2000 |
| Priority: | LO | Flags: | mgraesslin:
ReviewRequest+
|
| Version First Reported In: | 5.8.2 | ||
| Target Milestone: | --- | ||
| Platform: | Debian testing | ||
| OS: | Linux | ||
| URL: | https://phabricator.kde.org/D6719 | ||
| Latest Commit: | https://commits.kde.org/kwin/bf0e0f071cebf9238669ce4352f29cc3f061edcc | Version Fixed In: | 5.10.4 |
| Sentry Crash Report: | |||
| Attachments: |
Screenshot of a rolled up title bar
Problem with patch+Aurorae An Aurorae theme without border |
||
Doesn't happen with Breeze theme. Before you start wondering, the buttons are configured to be on the left. *** Bug 374419 has been marked as a duplicate of this bug. *** The same thing happens to Aurorae. This bug has been there for a long time. The problem is that Breeze's look is so elementary and it doesn't support translucency or fine-tuning, so many KWin users use Aurorae instead. The problem does neither happen when compositing is suspended nor when XRender compositing is used. I can reproduce with both xrender and compositing disabled. Debian buster(testing) with kwin-x11 5.8.7-1 (In reply to Alexander Schier from comment #7) And plastik deco. (In reply to Martin Flöser from comment #6) > The problem does neither happen when compositing is suspended nor when > XRender compositing is used. please ignore this comment, of course it happens also with XRender and no compositing. Happy to see there's an activity about this; just wanted to emphasize that the issue isn't specific to Plastik and, theoretically, any fix should solve the same problem in Aurorae too. Patch at https://phabricator.kde.org/D6719 Created attachment 106652 [details]
Problem with patch+Aurorae
I'm afraid the patch doesn't work well with Aurorae (although it works with Plastik). First, it doesn't do anything when BorderBottom=0. Second, if BorderBottom is set to a positive value -- even 1 -- the patch "works" weirdly because the whole bottom shadow will be given to the shaded window, as the attached screenshot shows.
Do you have me a theme with borderBottom=0 so that I can test? Created attachment 106653 [details]
An Aurorae theme without border
Attached is an Aurorae theme without (bottom) border but with large shadow. If I make a theme like it but with a bottom border of 1px, the shaded window will show a bottom border as thick as the shadow + 1px.
Thanks, unfortunately I can confirm that this theme still doesn't work. > unfortunately I can confirm that this theme still doesn't work.
Actually, any theme, with or without bottom border because even if there's a bottom border, although the titlebar text and buttons will be shown correctly, the bottom shadow height will be added to the bottom border on shading -- which is a new bug with the patch in question. To test, use a theme with large shadows -- like the attached one -- and with a bottom border.
I updated the patch, looks much better now. @Martin This time the patch works like a charm :) Thank you! Git commit bf0e0f071cebf9238669ce4352f29cc3f061edcc by Martin Flöser. Committed on 17/07/2017 at 14:51. Pushed by graesslin into branch 'Plasma/5.10'. [aurorae] Add support for shaded windows Summary: Aurorae did not render correctly. This change addresses the problem for both maximized and restored windows. FIXED-IN: 5.10.4 Test Plan: shaded windows with Plastik and SVG based theme Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D6719 M +2 -0 plugins/kdecorations/aurorae/src/aurorae.cpp M +1 -1 plugins/kdecorations/aurorae/src/qml/Decoration.qml https://commits.kde.org/kwin/bf0e0f071cebf9238669ce4352f29cc3f061edcc |
Created attachment 102634 [details] Screenshot of a rolled up title bar Steps to reproduce: - Use Plastik as Window Decoration - Roll up window (i.e. scroll with the mouse wheel on the title bar) - Text and Buttons disappear - You can see a tiny rest of the buttons at the top of the titlebar