Summary: | Connection between activity and pin does not end on pin | ||
---|---|---|---|
Product: | [Applications] umbrello | Reporter: | Ralf Habacker <ralf.habacker> |
Component: | general | Assignee: | Umbrello Development Group <umbrello-devel> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | okellogg |
Priority: | NOR | ||
Version: | Git | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | All | ||
Latest Commit: | https://commits.kde.org/umbrello/95a1547793bba6519ca7f277ccc1d218f8d871d5 | Version Fixed In: | 2.21.80 (KDE Applications 17.03.80) |
Description
Ralf Habacker
2016-12-05 19:26:20 UTC
My initial estimation of the related commit was wrong. Retesting on another machine shows that this happens on git master branch. The related commit is 703b25a024380dcb81895c9700c3a8d4d72cfb74 which adds pin and ports as QGraphicsItem child to the component or activity widget. My guess of the root cause is that fetching the position of the child widget with pos() returns the position relativ to the parent item. So fix this on the related locations it is required to use QGraphicsItem::scenePos() instead for example instead widget->x() it is required to use widget->scenePos().x() Git commit 95a1547793bba6519ca7f277ccc1d218f8d871d5 by Ralf Habacker. Committed on 06/12/2016 at 17:15. Pushed by habacker into branch 'master'. Fix 'Connection between activity and pin does not ends on pin'. FIXED-IN:2.21.80 (KDE Applications 17.03.80) M +2 -2 umbrello/toolbarstateassociation.cpp M +6 -6 umbrello/umlwidgets/associationwidget.cpp https://commits.kde.org/umbrello/95a1547793bba6519ca7f277ccc1d218f8d871d5 |