Bug 373128

Summary:	Incorrect behavior for "Copy image(s) to ..." menu
Product:	[Applications] kphotoalbum	Reporter:	Mark Harrison <mark.z.harrison>
Component:	Thumbnail Viewer	Assignee:	KPhotoAlbum Bugs <kphotoalbum-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	mark.z.harrison, tl
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Mark Harrison 2016-12-01 07:32:14 UTC

After selecting one or more images in the thumbnail viewer and selecting "Copy image(s) to ...". on the right-click menu, the file dialog that appears only allows the selection of an existing file. This does not make sense to me since I don't want to overwrite a file with the selected pictures. I just want to copy the pictures to another location.

In lines 93 and 99 of MainWindow/CopyPopUp.cpp, the QFileDialog has setFileMode( QFileDialog::ExistingFile ). Unless I'm misunderstanding this function, a better file mode would be QFileDialog::Directory, especially since, if copying all selected images, this line is run (line 100): dialog.setOption( QFileDialog::ShowDirsOnly, true).

Comment 1 Tobias Leupold 2016-12-01 08:33:32 UTC

This is actually a regression that happened during the KF5/Qt5 port. I'll fix it asap, thanks for the bug report :-)

Comment 2 Mark Harrison 2016-12-01 19:58:13 UTC

Thanks for the quick response. After thinking about it, I believe the file mode options should be

- Copy single picture: QFileDialog::AnyFile (in case the user wants to rename the copied picture, defaulted to the original file name)
- Copy multiple pictures: QFileDialog::Directory

Comment 3 Tobias Leupold 2016-12-01 22:49:17 UTC

Should be fixed with commit https://commits.kde.org/kphotoalbum/9a0f05662e2376f44799681a955e76e057dd86a3

If not, feel free to re-open this!