| Summary: | Grid layout does not wrap the theme's description | ||
|---|---|---|---|
| Product: | [Applications] systemsettings | Reporter: | Elvis Angelaccio <elvis.angelaccio> |
| Component: | kcm_sddm | Assignee: | David Edmundson <kde> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | filipfila.kde |
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/sddm-kcm/9094e982ff0cf5e18bc4aa1caaec582cb30d603f | Version Fixed/Implemented In: | 5.16 |
| Sentry Crash Report: | |||
| Attachments: | Screenshot of the bug | ||
Git commit 9094e982ff0cf5e18bc4aa1caaec582cb30d603f by Filip Fila.
Committed on 17/04/2019 at 07:07.
Pushed by filipf into branch 'master'.
Redesign the theme preview window
Summary:
This patch:
- makes the root element accommodate its content's dimensions so that information doesn't get cut off when using scaling or big fonts
- matches the root element's color to that of the surrounding space
- replaces the border around the image preview with a drop shadow
- ports the GridLayout to ColumnLayout to make sure content doesn't get lost horizontally when using scaling or big fonts
- ports Text elements to QQC2 Labels
- adds the theme name as a Kirigami heading
- constrains the labels within the layout's width, wrapping and eliding them if necessary
- removes the hardcoding of font sizes
- makes the email and website info clickable
FIXED-IN: 5.16
Test Plan:
Before:
{F6618593}
After:
{F6630795}
Reviewers: #plasma, #vdg, ngraham, GB_2
Reviewed By: #vdg, ngraham, GB_2
Subscribers: mart, GB_2, mmustac, davidedmundson, abetts, rooty, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D19077
M +103 -65 src/qml/main.qml
https://commits.kde.org/sddm-kcm/9094e982ff0cf5e18bc4aa1caaec582cb30d603f
|
Created attachment 102421 [details] Screenshot of the bug Descriptions defined in metadata.desktop of SDDM themes can be very long. For example the Elarun theme has: Description=Elarun KDM theme ported to SDDM. \nThe original theme is based on work of Roman Shtylman & Nuno Pinheiro Such a long text breaks the GridLayout in src/qml/main.qml (see attached screenshot)