Bug 372572

Summary:	[appimage] export GIF animation is broken, specific to appimage
Product:	[Applications] krita	Reporter:	David REVOY <info>
Component:	File formats	Assignee:	Krita Bugs <krita-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	bisketashwin, halla, walker275
Priority:	NOR
Version First Reported In:	3.1 Beta
Target Milestone:	---
Platform:	Appimage
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	log_file

Description David REVOY 2016-11-17 08:08:10 UTC

Created attachment 102265 [details]
log_file

Hi,

In the last beta appimage (krita-3.0.93-x86_64.appimage) the export *.gif animation is broken. After running the export, the frames are exported, but  Krita always display an error dialog and invite the user to read a log generated in the target folder. I pasted the log_palettegen.log file generated in attachement.

Here is a first diagnosis by Dmitry on IRC:
> <dmitryK|log> deevad: might be related to appimage...
> it cannot open the file where it should write the progress information
> <dmitryK|log> deevad: yes, it is appimage-related, just downloaded and tested it. Please make a report [...]

Comment 1 Halla Rempt 2016-11-17 10:54:00 UTC

Git commit 0a80b8e201d93e2294d7c9166c48e0b77fc59ff9 by Boudewijn Rempt.
Committed on 17/11/2016 at 10:52.
Pushed by rempt into branch 'krita/3.1'.

Refactor the filename requester and filedialog

The messing with relative paths to the default folder meant that
the user never could be sure which path we were going to save to.

Rendering to GIF still fails, though, but I need more brain to
figure out why.
Related: bug 372537

M  +2    -2    libs/ui/KisMainWindow.cpp
M  +9    -10   libs/widgets/kis_file_name_requester.cpp
M  +3    -5    libs/widgetutils/KoFileDialog.cpp
M  +1    -1    libs/widgetutils/KoFileDialog.h
M  +3    -1    plugins/extensions/animationrenderer/DlgAnimationRenderer.cpp
M  +2    -2    plugins/impex/video/video_saver.cpp

http://commits.kde.org/krita/0a80b8e201d93e2294d7c9166c48e0b77fc59ff9

Comment 2 Halla Rempt 2016-11-17 10:55:59 UTC

Git commit 3d61331e8b73434d31a5346024355f459202e49e by Boudewijn Rempt.
Committed on 17/11/2016 at 10:54.
Pushed by rempt into branch 'rempt/impex-refactoring'.

Refactor the filename requester and filedialog

The messing with relative paths to the default folder meant that
the user never could be sure which path we were going to save to.

Rendering to GIF still fails, though, but I need more brain to
figure out why.
Related: bug 372537

M  +2    -2    libs/ui/KisMainWindow.cpp
M  +9    -10   libs/widgets/kis_file_name_requester.cpp
M  +3    -5    libs/widgetutils/KoFileDialog.cpp
M  +1    -1    libs/widgetutils/KoFileDialog.h
M  +3    -1    plugins/extensions/animationrenderer/DlgAnimationRenderer.cpp
M  +2    -2    plugins/impex/video/video_saver.cpp

http://commits.kde.org/krita/3d61331e8b73434d31a5346024355f459202e49e

Comment 3 Scott Petrovic 2016-11-19 15:37:28 UTC

Git commit 5ea2b338f91875d216d7fbd1ec30b345c0bd5a5e by Scott Petrovic, on behalf of Boudewijn Rempt.
Committed on 19/11/2016 at 15:23.
Pushed by scottpetrovic into branch 'petrovic/impex-brush-editor-ui'.

Refactor the filename requester and filedialog

The messing with relative paths to the default folder meant that
the user never could be sure which path we were going to save to.

Rendering to GIF still fails, though, but I need more brain to
figure out why.
Related: bug 372537

M  +2    -2    libs/ui/KisMainWindow.cpp
M  +9    -10   libs/widgets/kis_file_name_requester.cpp
M  +3    -5    libs/widgetutils/KoFileDialog.cpp
M  +1    -1    libs/widgetutils/KoFileDialog.h
M  +3    -1    plugins/extensions/animationrenderer/DlgAnimationRenderer.cpp
M  +2    -2    plugins/impex/video/video_saver.cpp

http://commits.kde.org/krita/5ea2b338f91875d216d7fbd1ec30b345c0bd5a5e

Comment 4 mvowada 2016-11-30 19:13:57 UTC

*** Bug 371900 has been marked as a duplicate of this bug. ***

Comment 5 mvowada 2016-12-03 11:32:59 UTC

*** Bug 373206 has been marked as a duplicate of this bug. ***

Comment 6 Halla Rempt 2016-12-12 10:27:17 UTC

This works fine now.