Bug 372551

Summary: [WACOM] ExpressKeys leave input manager in messed up state
Product: [Applications] krita Reporter: Alex <irath96>
Component: Tablets (tablet issues are only very rarely bugs in Krita!)Assignee: Krita Bugs <krita-bugs-null>
Status: RESOLVED UPSTREAM    
Severity: normal CC: halla
Priority: NOR    
Version First Reported In: 3.1 Beta   
Target Milestone: ---   
Platform: macOS (DMG)   
OS: macOS   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description Alex 2016-11-16 19:53:51 UTC
I am using an Intuos Pro tablet on macOS Sierra 10.12.1.
I configured two ExpressKeys on my tablet:
Key #1: Presses shift key (for blending)
Key #2: Presses "cmd + z" (for undo)


Pressing Key #1 shows up like this in the tabletlog:
krita.tabletlog: "[       ] ShortcutOverride key: 0x1000020 mod: 0x2000000 text: none"
krita.tabletlog: "[       ] ShortcutOverride key: 0x1000024 mod: 0x2000000 text: none"
krita.tabletlog: "[       ] KeyRelease       key: 0x1000024 mod: 0x2000000 text: none"
krita.tabletlog: "[       ] ShortcutOverride key: 0x1000024 mod: 0x0 text: none"
krita.tabletlog: "[       ] KeyRelease       key: 0x1000020 mod: 0x0 text: none"
krita.tabletlog: "[       ] KeyRelease       key: 0x1000024 mod: 0x0 text: none"

For some reason, there is the 0x1000024 key, which seems to be also sent by my tablet for no apparent reason.


Pressing Key #2 shows up like this:
krita.tabletlog: "[       ] ShortcutOverride key: 0x1000021 mod: 0x4000000 text: none"
krita.tabletlog: "[       ] ShortcutOverride key: 0x1000024 mod: 0x4000000 text: none"
krita.tabletlog: "[       ] ShortcutOverride key: 0x5a mod: 0x4000000 text: none"
krita.tabletlog: "[       ] KeyRelease       key: 0x1000024 mod: 0x4000000 text: none"
krita.tabletlog: "[       ] ShortcutOverride key: 0x1000024 mod: 0x0 text: none"
krita.tabletlog: "[       ] KeyRelease       key: 0x1000021 mod: 0x0 text: none"
krita.tabletlog: "[       ] KeyRelease       key: 0x1000024 mod: 0x0 text: none"


When I am only using Key #1, everything is fine. But as soon as I press Key #2, it performs the undo, but from this point on only Key #2 will respond correctly. Pressing Key #1 shows no action. However it starts working again as soon as I either refocus the window or press a random key (no modifiers) on my keyboard. Apparently, Key #2 leaves the input manager in a messed up state.
Comment 1 Halla Rempt 2018-02-06 09:13:18 UTC
Please, check again with 3.3.3 or 4.0 beta 1. This looks like an issue that would be solved by  https://codereview.qt-project.org/#/c/179214.