Bug 372423

Summary: Hide unchanged files resets folder and doesn’t hide all elements
Product: [Applications] kdesvn Reporter: Karl Ove Hufthammer <karl>
Component: GeneralAssignee: KDESvn default assignee <kdesvn-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: Ch.Ehrlicher
Priority: NOR    
Version First Reported In: GIT (master)   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description Karl Ove Hufthammer 2016-11-13 09:59:18 UTC 
The ‘Hide unchanged files’ behaves strangely. There are several related issues:

1.
Observed behaviour:
When I check ‘Hide unchanged files’, the unchanged files *are* hidden, but at the same time the currently selected folder is reset to the top-level folder.

Expected behaviour:
The currently selected folder should remain selected (i.e. its content should be displayed in the right-hand pane) (as long as it contains any changes).


2.
Observed behaviour:
Unchanged folders (i.e. folders with no unchanged files/folders, recursively) are *not* hidden.

Expected behaviour:
Also unchanged folders should be hidden. See also the following point.


3.
Observed behaviour:
When *reloading* a project/URL (even the same project as was open) with the ‘Hide unchanged files’ option selected, also unchanged folders *are* hidden. That is, only folders and files containing any changes are shown in the folder panel. This is the *expected* behaviour, but should also happened when just enabling the hiding options, as described in the previous item.


4.
Observed behaviour:
After performing item 3 and then *unchecking* the ‘Hide unchanged files’ option, any unchanged folders are *still* hidden. So not all folders are available for selection. (One again has to reload the project/URL to be able to see the folders.)

Expected behaviour:
When unchecking the option, all folders and files should be displayed.
Comment 1 Christian Ehrlicher 2016-11-13 13:26:21 UTC 
I can confirm this behavior but currently have no real clue what's going on there. It also does not work with kdesvn (kde4/qt4) so at least it has nothing to do with the kf5 porting.
Comment 2 Christian Ehrlicher 2017-08-08 15:49:15 UTC 
Should be fixed with 55e5258f, opensuse tests rpms can be found here: https://build.opensuse.org/package/show/home:chehrlic/kdesvn5
Bug 1 happened because the selected folder was reset on every settings change which was wrong (only needed when switching to/from single view mode)
Bug 2-4 was because the folder view was not informed about the new filter settings and therefore the new filtering was not applied there.