Bug 372256

Summary: Krazy thinks QMessageBox is a Qt4 class
Product: [Developer tools] krazy Reporter: Elvis Angelaccio <elvis.angelaccio>
Component: generalAssignee: Allen Winter <winter>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description Elvis Angelaccio 2016-11-09 14:27:53 UTC 
Consider http://ebn.kde.org/krazy/reports/kde-4.x/kdeutils/ark/index.html

...
"Use KMessageBox instead of QMessageBox"
"Why should I care?" -> "Don't use Qt 4 classes that are deprecated"

But QMessageBox is a legit Qt5 class, so krazy should probably not warn about it.
Comment 1 Allen Winter 2016-11-09 17:51:33 UTC 
is this a matter of the explanation string being wrong or that we are ok using QMessageBox in some cases instead of KMessageBox?

last I knew, we should be using KMessageBox over QMessageBox in KDE applications.
Comment 2 Elvis Angelaccio 2016-11-09 18:00:13 UTC 
(In reply to Allen Winter from comment #1)
> is this a matter of the explanation string being wrong or that we are ok
> using QMessageBox in some cases instead of KMessageBox?
> 
> last I knew, we should be using KMessageBox over QMessageBox in KDE
> applications.

Right, this is more about the warning message (since it's not a Qt4 class).
Now that I think about it, if we still have KMessagebox there must be a reason and we should probably use it. So it makes sense that krazy looks for this.
Comment 3 Elvis Angelaccio 2016-11-09 18:01:09 UTC 
Title changed to better describe the report.