Bug 372211

Summary:	Chrome app icons replaced with generic chrome icon
Product:	[Plasma] plasmashell	Reporter:	Andras Soltesz <soltesz.andras>
Component:	Icons-only Task Manager	Assignee:	Eike Hein <hein>
Status:	RESOLVED FIXED
Severity:	major	CC:	kde, plasma-bugs-null
Priority:	NOR
Version First Reported In:	5.8.3
Target Milestone:	1.0
Platform:	Neon
OS:	Linux
Latest Commit:	http://commits.kde.org/plasma-workspace/7c443aa53900521deab4fcd4641ea5273afc294e	Version Fixed/Implemented In:	5.8.4
Sentry Crash Report:

Description Andras Soltesz 2016-11-08 12:54:17 UTC

For convenience, I use Gmail and other heavily used websites in separate windows (as opposed to browser tabs) using the websites' dedicated icons as window-icons.

I achieved this via creating Chrome Applications (apps) so I generated the .desktop files with Chrome.

Recently I updated from 5.8 to 5.8.3 and now the chrome app icons are not honored but replaced with generic Chrome icons on the Icons-only Task Manager.

This has worked perfectly in 5.8, so I guess it is a regression.

Comment 1 Eike Hein 2016-11-08 12:56:22 UTC

Please attach:

- xprop output for relevant windows
- path to custom .desktop file
- content of custom .desktop file

There haven't been anty code changes I'm aware of however.

Comment 2 Kai Uwe Broulik 2016-11-08 13:27:45 UTC

Google Chrome changed their classClass from "google-chrome" (for which we have a mapping rule) to "Google-Chrome" and also the resulting desktop file changed from "chrome-foo-default.desktop" to "chrome-foo-Default.desktop"...

Comment 3 Kai Uwe Broulik 2016-11-08 13:27:58 UTC

to Google-chrome, that is.

Comment 4 Kai Uwe Broulik 2016-11-08 14:16:20 UTC

Git commit 7c443aa53900521deab4fcd4641ea5273afc294e by Kai Uwe Broulik.
Committed on 08/11/2016 at 14:14.
Pushed by broulik into branch 'Plasma/5.8'.

[taskmanagerrulesrc] Add Rewrite Rule for Google-chrome

Google Chrome needlessly changed its window class class to Google-chrome
(was google-chrome previously) breaking our launcher mapping.
FIXED-IN: 5.8.4

Differential Revision: https://phabricator.kde.org/D3308

M  +7    -0    libtaskmanager/taskmanagerrulesrc

http://commits.kde.org/plasma-workspace/7c443aa53900521deab4fcd4641ea5273afc294e

Comment 5 Kai Uwe Broulik 2016-11-08 14:16:25 UTC

Git commit 61860066a4cea845598fa4904607db1bba411356 by Kai Uwe Broulik.
Committed on 08/11/2016 at 14:13.
Pushed by broulik into branch 'Plasma/5.8'.

[XWindowTasksModel] Check for service being empty before searching new ones

If our regular expression matching found a service but there was also some non-regular expression rule in the file,
it would overwrite a potentially valid service match.

Differential Revision: https://phabricator.kde.org/D3309

M  +1    -1    libtaskmanager/xwindowtasksmodel.cpp

http://commits.kde.org/plasma-workspace/61860066a4cea845598fa4904607db1bba411356