| Summary: | GUI angular control for Shadow light source shows incorrect angle (spinbox is correct) | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | Kirill Kustov <kustov1984> |
| Component: | layer styles | Assignee: | Krita Bugs <krita-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | artgoat, dimula73 |
| Priority: | NOR | ||
| Version: | 3.0.1.1 | ||
| Target Milestone: | --- | ||
| Platform: | Microsoft Windows | ||
| OS: | Microsoft Windows | ||
| Latest Commit: | https://commits.kde.org/krita/c099ae3e614d1686ac164316a793ea1a2a8ba225 | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: |
Not correctly
Circle Point |
||
Created attachment 102090 [details]
Circle Point
I understood bug.
The angle of the light source, location of the shadows are correctly.
Circle Point is incorrect. See attachement.
Circle Point is must be show angle of the light source.
The same problem in Inner Shadow. Circle point isn't moving correctly too. The shadow should be located on the opposite side of the circle (object). Only GUI control is not correct, the value itself is correct To clarify, the GUI control corresponds to the angle in the numerical selector box, but neither of them corresponds to the angle of the shadow in the preview on-screen. So the number agrees with the GUI spinner control (i.e. 0 is vertical, 90 is to the right, 180 is at the bottom and -90 is to the left), but the controls don't agree with what is actually on the layer. i.e. "0" puts the spinner dot at the top, the light source at the right, the shadow at the left "90" puts the spinner at the right, the light source at the top, the shadow at the bottom, "180" puts the spinner at the bottom, the light source at the left, the shadow to the right, "-90" puts the spinner at the left, the light source at the bottom, the shadow at the top. As the number increases, suggesting a clockwise rotation of the light source, the spinner moves clockwise as expected, but the apparent light source on the preview rotates counter-clockwise. This is probably a simple subtraction error somewhere. *** Bug 384662 has been marked as a duplicate of this bug. *** Git commit c099ae3e614d1686ac164316a793ea1a2a8ba225 by Anna Medonosova. Committed on 11/12/2018 at 16:48. Pushed by amedonosova into branch 'master'. Layer Styles UI: fix for angle selection, small UI tweaks Summary: 1, Fix for Bug 372169 - GUI angular control for Shadow light source shows incorrect angle (spinbox is correct) Adobe’s angle selection dial widget differs from QDial by 90 degrees. That creates the inconsistency between settings dialogs and layer effects. In this diff, angle selection is moved into dedicated widget, KisLayerStyleAngleSelector, which solves this problem for all layer style settings dialogs. Also lessens code duplication in this area. 2, Label alignment unification with proper use of QFormLayout Reviewers: #krita, rempt Reviewed By: #krita, rempt Subscribers: rempt Tags: #krita Differential Revision: https://phabricator.kde.org/D17134 M +3 -1 libs/ui/CMakeLists.txt M +25 -134 libs/ui/dialogs/kis_dlg_layer_style.cpp M +0 -24 libs/ui/dialogs/kis_dlg_layer_style.h M +38 -40 libs/ui/layerstyles/WdgGradientOverlay.ui M +37 -55 libs/ui/layerstyles/WdgSatin.ui M +52 -41 libs/ui/layerstyles/WdgStroke.ui M +62 -106 libs/ui/layerstyles/wdgBevelAndEmboss.ui A +95 -0 libs/ui/layerstyles/wdgKisLayerStyleAngleSelector.ui M +67 -103 libs/ui/layerstyles/wdgdropshadow.ui A +117 -0 libs/ui/widgets/KisLayerStyleAngleSelector.cpp [License: LGPL] A +68 -0 libs/ui/widgets/KisLayerStyleAngleSelector.h [License: LGPL] https://commits.kde.org/krita/c099ae3e614d1686ac164316a793ea1a2a8ba225 |
Created attachment 102088 [details] Not correctly Hello! I set the angle of the light source -45 in drop shadow (Layer style). See attachment. Shadow moves to light source. It is not corectly. Shadow should be located in the lower right corner. The location of the shadow is not correctly in another angles too. Sorry for my English.