Bug 372113

Summary:	Regression: in KF5 deletes bookmark without confirmation and with no undo
Product:	[Applications] keditbookmarks	Reporter:	Jonathan Marten <jjm>
Component:	general	Assignee:	Konqueror Bugs <konqueror-bugs-null>
Status:	RESOLVED WORKSFORME
Severity:	normal	CC:	lueck
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Jonathan Marten 2016-11-05 17:34:49 UTC

The KDE4 version of keditbookmarks had Undo and Redo actions (in their expected place in the "Edit" menu).  This meant that an unintended delete of a bookmark or folder could be reversed.

Now in the KF5 versions these actions appear to be not present.  This means that deleting a bookmark happens immediately without confirmation, with no way of undoing the action or recovering the deleted bookmark.

The delete action should either prompt for confirmation, or it should be able to be undone.

This is keditbookmarks version 5.0 started standalone (i.e. not from within Konqueror).

Comment 1 Burkhard Lück 2016-11-06 08:14:34 UTC

keditbookmarks build from the new repo commits.kde.org/keditbookmarks (splitted fron kde-baseapps) has Undo + Redo action, they wotks as properly as in the kde4 version.
Please update + try again

Comment 2 Christoph Feck 2016-11-07 00:36:56 UTC

Cannot confirm either. Undo worked after delete in KF5 version of keditbookmarks, started from Konsole.

If you did compile keditbookmarks yourself, it is possible that you did not install it correctly. In this case, it might not find the required ui.rc files and therefor lack some menu entries.

Comment 3 Jonathan Marten 2016-11-18 08:12:03 UTC

Works perfectly in the split KF5 version. Apoogies for the spurious report.