| Summary: | export COLORTERM=truecolor | ||
|---|---|---|---|
| Product: | [Applications] konsole | Reporter: | Egmont Koblinger <egmont> |
| Component: | general | Assignee: | Konsole Developer <konsole-devel> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | 4wy78uwh, heri+kde |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/konsole/8d32afabb564ae124e06e233be5c5300da906aea | Version Fixed In: | |
| Sentry Crash Report: | |||
|
Description
Egmont Koblinger
2016-10-31 23:24:24 UTC
Just FYI: iTerm2 counterpart filed at https://gitlab.com/gnachman/iterm2/issues/5294. So you want it added to the environment like TERM=term? You can do that manually by Profile->Environment (COLORTERM=truecolor). I assume you want it by default? Yup, I'm asking to add it by default so that users get true color support in mc out of the box in a couple of months from now, and developers of other apps also see this as the pattern to be continued. Git commit 8c7f165ed6fe1b72e5dfecd1ab24deaddedf9fd6 by Kurt Hindenburg. Committed on 19/11/2016 at 19:39. Pushed by hindenburg into branch 'master'. Add COLORTERM=truecolor to the environment M +1 -1 src/Profile.cpp http://commits.kde.org/konsole/8c7f165ed6fe1b72e5dfecd1ab24deaddedf9fd6 Thanks for your patch! Reopening for some more discussion: Your patch just made me realize that konsole doesn't even advertise 256-color support (TERM is set to xterm rather than xterm-256color). With this patch, it still doesn't advertise support for the pretty widespread 256-color feature, yet it advertises the less common true colors. This doesn't make too much sense to me. S-lang also seems to obey these pieces of information, and refuses to use the 256-color palette, yet allows true colors. Strictly speaking, these are two orthogonal features, and theoretically there could exist a terminal emulator that supports RGB but not the 256-color palette (although I'd be really surprised if it turned out that there exists/existed/will ever exist one). So one can kinda defend this behavior, we could leave konsole as-is, and I could modify the Midnight Commander patch accordingly. In practice, since the true color feature is getting more and more popular because 256 colors is not enough for some people, I'd say it's more practical to think about it as the true color being something that might be implemented, but only after you've got the 256-color palette anyways. MC's current implementation also does this, it has a sanity check for 256-color support according to terminfo before allowing true colors subject to COLORTERM, and it's expected that if a skin definition mentions the usage of true colors then 256-colors are allowed too. So the question is: Which direction do you think is the better? Have you already considered, or could you please consider switching the default to xterm-256color? That would simplify this situation a lot, actually we could just ignore this problem. Has this perhaps been already discussed and rejected for a reason? I found bug 212145 which seems to got forgotten, maybe time to revive? (Just FYI: gnome-terminal changed the default to xterm-256color in vte-0.40, released in March 2015.) Thanks! Just occurred to me: _if_ terminfo's maintainer wasn't so much against true colors, support would I guess be added in a way that the existing "tput colors" reported 16 million. That is, it wouldn't have the concept of two orthogonal features, rather than just one parameter set to 8, 16, 88, 256 or 16M. In other words, I think it would make 256-color support a prerequisite for 16M. Git commit 8d32afabb564ae124e06e233be5c5300da906aea by Kurt Hindenburg. Committed on 24/11/2016 at 14:41. Pushed by hindenburg into branch 'Applications/16.12'. Add COLORTERM=truecolor to the environment (cherry picked from commit 8c7f165ed6fe1b72e5dfecd1ab24deaddedf9fd6) M +1 -1 src/Profile.cpp https://commits.kde.org/konsole/8d32afabb564ae124e06e233be5c5300da906aea Git commit 2671800b084cf89f1a91c6b3fdf93eb3b8078672 by Kurt Hindenburg. Committed on 24/11/2016 at 16:29. Pushed by hindenburg into branch 'master'. set default TERM=xterm-256color Change TERM=xterm to xterm-256color Related: bug 212145 M +1 -1 src/Profile.cpp M +1 -1 src/Pty.cpp https://commits.kde.org/konsole/2671800b084cf89f1a91c6b3fdf93eb3b8078672 Git commit d5cac9d2f1a1225d19c0be6b51e3db6e4aaed3d4 by Kurt Hindenburg. Committed on 24/11/2016 at 16:32. Pushed by hindenburg into branch 'Applications/16.12'. set default TERM=xterm-256color Change TERM=xterm to xterm-256color Related: bug 212145 (cherry picked from commit 2671800b084cf89f1a91c6b3fdf93eb3b8078672) M +1 -1 src/Profile.cpp M +1 -1 src/Pty.cpp https://commits.kde.org/konsole/d5cac9d2f1a1225d19c0be6b51e3db6e4aaed3d4 |