|Summary:||Saving Avatar as .face is totally broken|
|Product:||[Plasma] user-manager||Reporter:||Richard Llom <richard.llom>|
|Component:||kcontrol module||Assignee:||Jonathan Riddell <jr>|
|Latest Commit:||https://commits.kde.org/user-manager/0d43e0379a16fe5f2c58a69ff2db1cf14c28197e||Version Fixed In:|
Description Richard Llom 2016-10-25 12:55:24 UTC
I'm referring to the saving of the avatar as .face and .face icon (link to the former file) for displaying the avatar on the SDDM login screen (which also doesn't work but I guess this is another issue). So one can change the avatar of any user as many times as one would like, however the .face & link file is only created once and never recreated/updated afterwards. (The avatar displayed in the user manager is apparently saved somewhere else.) Reproducible: Always Steps to Reproduce: 1. Set avatar for new user 2. Notice how .face&link is created accordingly. 3. Change avatar (or delete .face in home of new user) Actual Results: No new .face and .face.icon is created Expected Results: New .face and .face.icon is created upon change of avatar.
Comment 1 David Edmundson 2017-01-13 15:27:11 UTC
Git commit 0d43e0379a16fe5f2c58a69ff2db1cf14c28197e by David Edmundson. Committed on 13/01/2017 at 15:27. Pushed by davidedmundson into branch 'Plasma/5.9'. When updating another user's avatar don't save icon into our home Summary: We want to save the face using AccountsService, but for backwards compatibility we also save the icon into ~/.face for old apps/DisplayManagers that still expect that. This works when setting a face as the current user, but doesn't make sense when setting the icon of another user. We can't fix it to write into another user's home, so instead of trying just skip that step and only update AccountsService. Related: bug 365662, bug 360005 Test Plan: Changed my user's avatar. AccountsService updated ~/.face updated Changed another user's avatar from my account. Accounts service updated, ~/.face was unchanged Reviewers: #plasma, mart Reviewed By: mart Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D4036 M +25 -14 src/accountinfo.cpp https://commits.kde.org/user-manager/0d43e0379a16fe5f2c58a69ff2db1cf14c28197e