Summary: | Saving Avatar as .face is totally broken | ||
---|---|---|---|
Product: | [Unmaintained] user-manager | Reporter: | Richard Llom <richard.llom> |
Component: | kcontrol module | Assignee: | Jonathan Riddell <jr> |
Status: | RESOLVED FIXED | ||
Severity: | grave | ||
Priority: | NOR | ||
Version: | 5.8.2 | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/user-manager/0d43e0379a16fe5f2c58a69ff2db1cf14c28197e | Version Fixed In: | |
Sentry Crash Report: |
Description
Richard Llom
2016-10-25 12:55:24 UTC
Git commit 0d43e0379a16fe5f2c58a69ff2db1cf14c28197e by David Edmundson. Committed on 13/01/2017 at 15:27. Pushed by davidedmundson into branch 'Plasma/5.9'. When updating another user's avatar don't save icon into our home Summary: We want to save the face using AccountsService, but for backwards compatibility we also save the icon into ~/.face for old apps/DisplayManagers that still expect that. This works when setting a face as the current user, but doesn't make sense when setting the icon of another user. We can't fix it to write into another user's home, so instead of trying just skip that step and only update AccountsService. Related: bug 365662, bug 360005 Test Plan: Changed my user's avatar. AccountsService updated ~/.face updated Changed another user's avatar from my account. Accounts service updated, ~/.face was unchanged Reviewers: #plasma, mart Reviewed By: mart Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D4036 M +25 -14 src/accountinfo.cpp https://commits.kde.org/user-manager/0d43e0379a16fe5f2c58a69ff2db1cf14c28197e |