Bug 371592

Summary:	interface issue with Add images dialog
Product:	[Applications] krita	Reporter:	animtim
Component:	Usability	Assignee:	Krita Bugs <krita-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version First Reported In:	git master (please specify the git hash!)
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	http://commits.kde.org/krita/ae39d79a9b9c6898cb4d54fd95cd59c388e93d85	Version Fixed/Implemented In:
Sentry Crash Report:

Description animtim 2016-10-24 17:34:20 UTC

In import animation frames, 
when clicking the add images button, 
it opens a qt file explorer, and all cpus spikes at 100% while it's open.. 
clicking on one file name closes it directly and loads the file, but if I just try to click Cancel, I've to click it a lot of times to make it close.. and if I select several files (which is expected for sequence import..), it's the same: I've to click ok a looot of times to make it work.

I can reproduce on both my laptop and desktop with different Qt versions.


Reproducible: Always

Comment 1 animtim 2016-10-24 21:29:15 UTC

Git commit ae39d79a9b9c6898cb4d54fd95cd59c388e93d85 by Timothée Giet.
Committed on 24/10/2016 at 21:28.
Pushed by timotheegiet into branch 'master'.

I noticed this bug came from mainWindow->showOpenFileDialog();
I first replaced it with a standard QFileDialog::getOpenFileName();, which worked, but didn't have all the properties set.
So I copied showOpenFileDialog there, and issue is gone.
It's maybe not the cleanest fix, but it does work.

M  +17   -1    libs/ui/dialogs/kis_dlg_import_image_sequence.cpp
M  +1    -0    libs/ui/dialogs/kis_dlg_import_image_sequence.h

http://commits.kde.org/krita/ae39d79a9b9c6898cb4d54fd95cd59c388e93d85

Comment 2 animtim 2016-10-24 21:29:15 UTC

Git commit ae39d79a9b9c6898cb4d54fd95cd59c388e93d85 by Timothée Giet.
Committed on 24/10/2016 at 21:28.
Pushed by timotheegiet into branch 'master'.

I noticed this bug came from mainWindow->showOpenFileDialog();
I first replaced it with a standard QFileDialog::getOpenFileName();, which worked, but didn't have all the properties set.
So I copied showOpenFileDialog there, and issue is gone.
It's maybe not the cleanest fix, but it does work.

M  +17   -1    libs/ui/dialogs/kis_dlg_import_image_sequence.cpp
M  +1    -0    libs/ui/dialogs/kis_dlg_import_image_sequence.h

http://commits.kde.org/krita/ae39d79a9b9c6898cb4d54fd95cd59c388e93d85