| Summary: | Drop GENERATE_MOC from kconfig_add_kcfg_files macro | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] frameworks-kconfig | Reporter: | Elvis Angelaccio <elvis.angelaccio> |
| Component: | general | Assignee: | Aleix Pol <aleixpol> |
| Status: | RESOLVED WORKSFORME | ||
| Severity: | normal | CC: | aleixpol, kdelibs-bugs |
| Priority: | NOR | ||
| Version: | 5.27.0 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| URL: | https://git.reviewboard.kde.org/r/129188/ | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
|
Description
Elvis Angelaccio
2016-10-24 09:53:52 UTC
On it, had to do a pit stop: https://phabricator.kde.org/D3178 Git commit 91dbd2f5a30caf878f668e60b7c2ee5ca376b858 by Aleix Pol. Committed on 30/10/2016 at 23:27. Pushed by apol into branch 'master'. Make kconfig_compiler autotests use the KCONFIG_ADD_KCFG_FILES Summary: Instead of having an odd fake of it. Will help some required refactorings and already showed some issues, fixed by this patch, namely: - don't use string(regex replace) to extract a string from another string. in case it doesn't match it will offer the whole content which is never what we want. - messages(ERROR), the correct parameter is FATAL_ERROR, cmake understands "ERROR" as mere output string - turn the macro into a function, otherwise 2 calls in the same subdirectory are dangerous. Test Plan: tests still pass, projects that use the macro still build Reviewers: #frameworks, dfaure Reviewed By: dfaure Subscribers: dfaure Differential Revision: https://phabricator.kde.org/D3178 M +18 -9 KF5ConfigMacros.cmake M +12 -29 autotests/kconfig_compiler/CMakeLists.txt M +1 -0 autotests/kconfig_compiler/test1.kcfgc M +1 -0 autotests/kconfig_compiler/test12.kcfgc M +1 -0 autotests/kconfig_compiler/test13.kcfgc M +1 -0 autotests/kconfig_compiler/test9.kcfgc M +1 -1 autotests/kconfig_compiler/test_qdebugcategory.kcfgc http://commits.kde.org/kconfig/91dbd2f5a30caf878f668e60b7c2ee5ca376b858 Git commit 187235b7a296bb7e01e51ef8b160ec08d8e7e000 by Aleix Pol. Committed on 06/11/2016 at 23:16. Pushed by apol into branch 'master'. Properly parse function keywords Summary: Use cmake_parse_arguments() instead of roughly implementing it locally Test Plan: recompiled everything, nothing broke Reviewers: #frameworks, dfaure Reviewed By: dfaure Differential Revision: https://phabricator.kde.org/D3251 M +5 -16 KF5ConfigMacros.cmake http://commits.kde.org/kconfig/187235b7a296bb7e01e51ef8b160ec08d8e7e000 Thank you for reporting this bug in KDE software. As it has been a while since this issue was reported, can we please ask you to see if you can reproduce the issue with a recent software version? If you can reproduce the issue, please change the status to "REPORTED" when replying. Thank you! Dear Bug Submitter, This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular bug tracker maintenance, if the bug is still in NEEDSINFO status with no change in 30 days the bug will be closed as RESOLVED > WORKSFORME due to lack of needed information. For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging If you have already provided the requested information, please mark the bug as REPORTED so that the KDE team knows that the bug is ready to be confirmed. Thank you for helping us make KDE software even better for everyone! This bug has been in NEEDSINFO status with no change for at least 30 days. The bug is now closed as RESOLVED > WORKSFORME due to lack of needed information. For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging Thank you for helping us make KDE software even better for everyone! |