| Summary: | Support color temperature adjustments in Wayland (like Redshift in X11 or f.lux) | ||
|---|---|---|---|
| Product: | [Plasma] kwin | Reporter: | G360 <kde-bugs.9ek5t> |
| Component: | platform-drm | Assignee: | Roman Gilg <subdiff> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | bugseforuns, david, francois5537, kamikazow, kwin-bugs-null, lukas, martin+kde, nate, subdiff |
| Priority: | NOR | Flags: | mgraesslin:
Wayland+
|
| Version: | git master | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/kwin/82d286046907c07050ebb8c8f5c09cb60079c3ae | Version Fixed In: | |
| Sentry Crash Report: | |||
|
Description
G360
2016-10-22 19:56:48 UTC
Can confirm. Tried your steps to reproduce. Eyes hurt. I would even go a little bit further: On X you need to install an additional plasmoid. I would like to have this feature per default in Plasma, because it's per default on Android and even activated there. *** Bug 373435 has been marked as a duplicate of this bug. *** I read this article (and the comments on Reddit about it ;) ). I created this task some time ago: https://phabricator.kde.org/T4465 But I hadn't yet the time to look more into it. If anybody else wants to try to code it, I would try to give assistance to him/her. In case someone is interested, sway supports this with a modified version of redshift. https://github.com/SirCmpwn/sway/pull/1019 The question is why isn't this in redshift directly? Also I would like to have this capability in KWin directly and without the user needing to install any third-party tools (maybe depend on the redshift lib, but not any fork). Any counter-arguments? This is the discussion: https://github.com/jonls/redshift/issues/55 *** Bug 379762 has been marked as a duplicate of this bug. *** Git commit 82d286046907c07050ebb8c8f5c09cb60079c3ae by Roman Gilg. Committed on 11/12/2017 at 09:58. Pushed by romangilg into branch 'master'. [colorcorrection] Night Color - blue light filter at nighttime With Wayland KWin needs to provide certain services, which were provided before that by the Xserver. One of these is gamma correction, which includes the - by many people beloved - functionality to reduce the blue light at nighttime. This patch provides the KWin part of that. It is self contained, but in the end will work in tandem with a lib in Plasma Workspace and a KCM in Plasma Desktop, which can be used to configure Night Color. * Three modi: ** Automatic: The location and sun timings are determined automatically (location data updates will be provided by the workspace) ** Location: The sun timings are determined by fixed location data ** Timings: The sun timings are set manually by the user * Color temperature value changes are smoothly applied: ** Configuration changes, which lead to other current values are changed in a quick way over a few seconds ** Changes on sunrise and sunset are applied slowly over the course of few minutes till several hours depending on the configuration * The current color value is set immediately at startup or after suspend phases and VT switches. There is no flickering. * All configuration is done via a DBus interface, changed values are tested on correctness and applied atomically * Self contained mechanism, speaks directly to the hardware by setting the gamma ramps on the CRTC * Currently working on DRM backend, extensible to other platform backends in the future * The code is written in a way to make the classes later easily extendable to also provide normal color correction, as it's currently done by KGamma on X Test Plan: Manually with the workspace parts and added integration tests in KWin using the virtual backend. Reviewers: #kwin, graesslin Subscribers: kwin, plasma-devel, #kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D5928 M +19 -0 CMakeLists.txt M +1 -0 autotests/integration/CMakeLists.txt A +334 -0 autotests/integration/colorcorrect_nightcolor_test.cpp [License: GPL (v2)] A +56 -0 colorcorrection/colorcorrect_settings.kcfg A +8 -0 colorcorrection/colorcorrect_settings.kcfgc A +54 -0 colorcorrection/colorcorrectdbusinterface.cpp [License: GPL (v2)] A +126 -0 colorcorrection/colorcorrectdbusinterface.h [License: GPL (v2)] A +288 -0 colorcorrection/constants.h [License: GPL (v2)] A +50 -0 colorcorrection/gammaramp.h [License: GPL (v2)] A +766 -0 colorcorrection/manager.cpp [License: GPL (v2)] A +147 -0 colorcorrection/manager.h [License: GPL (v2)] A +163 -0 colorcorrection/suncalc.cpp [License: GPL (v2)] A +47 -0 colorcorrection/suncalc.h [License: GPL (v2)] A +22 -0 org.kde.kwin.ColorCorrect.xml M +3 -0 platform.cpp M +31 -0 platform.h M +18 -0 plugins/platforms/drm/drm_backend.cpp M +6 -0 plugins/platforms/drm/drm_backend.h M +11 -0 plugins/platforms/drm/drm_object_crtc.cpp M +10 -0 plugins/platforms/drm/drm_object_crtc.h M +11 -0 plugins/platforms/virtual/virtual_backend.cpp M +12 -0 plugins/platforms/virtual/virtual_backend.h https://commits.kde.org/kwin/82d286046907c07050ebb8c8f5c09cb60079c3ae |