Bug 371475

Summary: OSD textBuffer has unbounded size
Product: [Applications] konversation Reporter: Jason Tibbitts <j>
Component: notificationsAssignee: Konversation Bugs <konversation-bugs-null>
Status: REPORTED ---    
Severity: normal    
Priority: NOR    
Version First Reported In: 1.6.2   
Target Milestone: ---   
Platform: Fedora RPMs   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description Jason Tibbitts 2016-10-22 05:09:04 UTC 
I use znc and let it buffer messages while I'm offline, so when konversation connects it may get hundreds of messages sent all at once.  This results in the OSD going through messages, one at a time, for quite a long time.  (Really, I've had it go for several hours before.)

In viewer/osd.cpp, OSDWidget::show() will append the string to be shown to textBuffer if the timer hasn't expired.  It seems to me that a quick check of textBuffer.size() to limit the queue to something like 20, or (60 / (the message display time in seconds)) would solve the problem and not really lose any useful information, since any messages you'd display after that would be somewhat out of date.

It's been over 20 years since I wrote any C++ so I don't have a patch to contribute, but I figured I'd open this so I don't lose the bit of research I just did.  If I can find the time I'll try to hack something up, but of course I don't really know what I'm doing.

Reproducible: Always

Steps to Reproduce:
Connect to ZNC with a lot of buffered content.

Actual Results:  
OSD flashes through messages for five or six hours.

Expected Results:  
OSD flashes through some content, but only queues enough messages to run for about a minute.
Comment 1 Justin Zobel 2022-10-26 03:07:03 UTC 
Thank you for reporting this bug in KDE software. As it has been a while since this issue was reported, can we please ask you to see if you can reproduce the issue with a recent software version?

If you can reproduce the issue, please change the status to "REPORTED" when replying. Thank you!
Comment 2 Jason Tibbitts 2022-10-27 16:08:02 UTC 
Yes, the behavior still exists.  I normally keep the OSD disabled because of this, so I turned it on and when I started konversation the this morning, the OSD just slowly went through through the znc backlog for 20 minutes until I turned it off again.