Bug 371249

Summary:	Buttons are aligned incorrectly on logout screen with russian language
Product:	[Unmaintained] ksmserver	Reporter:	sergei.chernikov
Component:	ui	Assignee:	Lubos Lunak <l.lunak>
Status:	RESOLVED FIXED
Severity:	normal	CC:	rootlexx
Priority:	NOR
Version First Reported In:	5.9.4
Target Milestone:	---
Platform:	Ubuntu
OS:	Linux
URL:	http://i.imgur.com/co24fZK.png
Latest Commit:	https://commits.kde.org/plasma-workspace/3e495b220fd09cdafa9873393be5c9e3fb055d44	Version Fixed/Implemented In:	5.11.2
Sentry Crash Report:
Attachments:	Logout screen buttons alignment before applying the proposed patch Proposed patch which fixes logout screen buttons alignment Logout screen buttons alignment after applying the proposed patch

Description sergei.chernikov 2016-10-19 20:27:13 UTC

In russian language (maybe in some others too) two buttons located higher than the rest.



Reproducible: Always

Steps to Reproduce:
1. Select russian language in regional settings
2. Reboot
3. Click shutdown in kickoff

Actual Results:  
Two buttons located higher than the rest

Expected Results:  
Buttons vertically aligned by the top of the buttons

Seems like this is because these buttons have two lines in the label and they aligned vertically by center.

Comment 1 Алексей Шилин 2017-10-04 19:14:22 UTC

I can confirm this bug.

Indeed, it's caused by QML Layout alignment being Qt.AlignVCenter by default, and becomes visible when LogoutButton text label splits into several rows.

A trivial one-liner fixes the issue (see the attachments).

P.S. I guess, this bug should have been reported against Product: plasmashell / Component: Look & Feel package.

Comment 2 Алексей Шилин 2017-10-04 19:15:41 UTC

Created attachment 108166 [details]
Logout screen buttons alignment before applying the proposed patch

Comment 3 Алексей Шилин 2017-10-04 19:16:52 UTC

Created attachment 108167 [details]
Proposed patch which fixes logout screen buttons alignment

Comment 4 Алексей Шилин 2017-10-04 19:17:34 UTC

Created attachment 108168 [details]
Logout screen buttons alignment after applying the proposed patch

Comment 5 Christoph Feck 2017-10-18 10:12:55 UTC

Алексей, could you submit the patch using https://phabricator.kde.org/differential/diff/create/ for review? Use Plasma group as reviewers.

Comment 6 Алексей Шилин 2017-10-21 13:07:35 UTC

(In reply to Christoph Feck from comment #5)
> Алексей, could you submit the patch using
> https://phabricator.kde.org/differential/diff/create/ for review? Use Plasma
> group as reviewers.

Done.

https://phabricator.kde.org/D8397

Comment 7 Christoph Feck 2017-10-25 18:46:47 UTC

Git commit 3e495b220fd09cdafa9873393be5c9e3fb055d44 by Christoph Feck, on behalf of Алексей Шилин.
Committed on 25/10/2017 at 18:44.
Pushed by cfeck into branch 'Plasma/5.11'.

Align logout screen action buttons to the top

Reviewed by: davidedmundson
FIXED-IN: 5.11.2

Differential Revision: https://phabricator.kde.org/D8397

M  +1    -0    lookandfeel/contents/logout/LogoutButton.qml

https://commits.kde.org/plasma-workspace/3e495b220fd09cdafa9873393be5c9e3fb055d44