Summary: | DPI field shows: 300 DPI (I18N_EXCESS_ARGUMENTS_SUPPLIED) | ||
---|---|---|---|
Product: | [Frameworks and Libraries] libksane | Reporter: | Heinrich Schuchardt <xypron.glpk> |
Component: | general | Assignee: | Pino Toscano <pino> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | casta+kde, jscott, kde, mirh, pino |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Debian stable | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/graphics/libksane/commit/f88f843d5e143b4b5b89119189d720d616c01cbe | Version Fixed In: | 20.07.80 |
Description
Heinrich Schuchardt
2016-10-16 07:56:52 UTC
The command line shows this output: "1 instead of 0 arguments to message { DPI} supplied before conversion." I think #386053 might be related Still a thing in latest git. Git commit dd39e1fb2f2da6d4f2d8b70366441dc0044117fb by Pino Toscano. Committed on 06/07/2020 at 17:10. Pushed by pino into branch 'master'. i18n: add placeholder to KSaneOption::unitString() strings The resulting string is set as suffix for KPluralHandlingSpinBox. KPluralHandlingSpinBox updates its text on value change replacing the value as placeholder/argument in the suffix string; if the KLocalizedString suffix does not have a placeholder, there will be a command line warning about the extra placeholder. FIXED-IN: 20.07.80 M +6 -6 src/options/ksaneoption.cpp https://invent.kde.org/graphics/libksane/commit/dd39e1fb2f2da6d4f2d8b70366441dc0044117fb Sorry, I just realized the change in libksane is wrong: the result is that the value will be shown twice, once by the spin box itself and the other as its suffix. Instead, I will fix KPluralHandlingSpinBox to not attempt to substitute the value in the suffix KLocalizedString. Actually I take it back: the issue is in libkscan: the KLocalizedString object for KPluralHandlingSpinBox::setSuffix() must be a plural string. Git commit f88f843d5e143b4b5b89119189d720d616c01cbe by Pino Toscano. Committed on 06/07/2020 at 22:04. Pushed by pino into branch 'master'. i18n: use plural forms for KSaneOption::unitString() strings The resulting string is set as suffix for KPluralHandlingSpinBox. KPluralHandlingSpinBox tries to substitute the value, so the KLocalizedString set must be either a plural form. Hence, make all the strings returned by KSaneOption::unitString() as plural forms. FIXED-IN: 20.07.80 M +4 -4 src/options/ksaneoption.cpp https://invent.kde.org/graphics/libksane/commit/f88f843d5e143b4b5b89119189d720d616c01cbe Awesome! I was just about to file this as a bug and have the exact same issue with the exact same scanner :) |