Bug 370653

Summary:	Group clips don't ungroup when undoing with Ctrl+Z
Product:	[Applications] kdenlive	Reporter:	Matthias Paillard <matthias.paillard>
Component:	User Interface	Assignee:	Jean-Baptiste Mardelle <jb>
Status:	RESOLVED FIXED
Severity:	normal	CC:	j.wuensch, oluja, wegwerf-1-2-3
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Ubuntu
OS:	Linux
Latest Commit:		Version Fixed In:

Description Matthias Paillard 2016-10-13 14:56:35 UTC

If I group two clips, I can't undo it with Ctrl+Z. It can get weird behavior if the clips were moved around because Kdenlive will act as if the two groups were always grouped together. It nonetheless undo ungrouping clips.

Reproducible: Always

Steps to Reproduce:
1. Group two clips (Select them, Ctrl+G or right click)
2. Try to undo it. (Ctrl+Z or Edit and Undo)

Comment 1 Wegwerf 2016-10-18 17:59:13 UTC

Matthias, which Kdenlive version are you using? Also, can you please be more specific? The first paragraph doesn't match the steps to reproduce. Can you please give the exact steps so that we can quickly reproduce this issue? Thank you very much for your cooperation!

Comment 2 oluja 2016-10-19 13:47:11 UTC

I have the same issue. With Ctrl+Z it dosnt work. Works only with undo clips.

Comment 3 Johannes Wuensch 2016-10-26 22:28:38 UTC

I am unable to reproduce this bug here on Linux Manjaro with kdenlive 16.08.2

When I group the clips with Ctrl+G, undo works just fine. BUT there is indeed a bug if I just select several clips at once with shift, move them and then try to undo it. (without actually grouping them.

I've already created a separate bug report with a quick screencast for that one: 
https://bugs.kde.org/show_bug.cgi?id=371353

Comment 4 Jean-Baptiste Mardelle 2016-11-15 22:51:39 UTC

Git commit 12217947db4b232463cfb87d400f63a0453fbd22 by Jean-Baptiste Mardelle.
Committed on 15/11/2016 at 22:51.
Pushed by mardelle into branch 'master'.

Fix undo grouping broken

M  +3    -3    src/timeline/customtrackview.cpp

http://commits.kde.org/kdenlive/12217947db4b232463cfb87d400f63a0453fbd22

Comment 5 Albert Astals Cid 2016-11-15 22:54:46 UTC

Git commit d25e1db8b7c7db083482bd2fb545ac7cfe571b2b by Albert Astals Cid, on behalf of Jean-Baptiste Mardelle.
Committed on 15/11/2016 at 22:54.
Pushed by aacid into branch 'Applications/16.12'.

Fix undo grouping broken

M  +3    -3    src/timeline/customtrackview.cpp

http://commits.kde.org/kdenlive/d25e1db8b7c7db083482bd2fb545ac7cfe571b2b