| Summary: | Global keyboard shortcut for KDE Daemon:Toggle Touchpad actually maps to Disable Touchpad | ||
|---|---|---|---|
| Product: | [Applications] systemsettings | Reporter: | andydecleyre |
| Component: | kcm_touchpad | Assignee: | Plasma Bugs List <plasma-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | aacid, alanm, andydecleyre, bugseforuns, burneddi, frederick888, kishore96, luca, marceloatie, nate, ndcunliffe, rafneq, rajeeshknambiar, simonandric5, slartibart70, s_chriscollins, thesourcehim |
| Priority: | NOR | ||
| Version: | 5.17.5 | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
|
Description
andydecleyre
2016-10-12 20:17:40 UTC
Can you confirm the input driver? $xlsatoms | grep -i tap I have observed this behaviour in 5.8 as well, but there was no code change in touchpad daemon affecting this. Will take a closer look. I have the same problem (also in 5.7): $ xlsatoms | grep -i tap 306 libinput Tapping Enabled 307 libinput Tapping Enabled Default 308 libinput Tapping Drag Enabled 309 libinput Tapping Drag Enabled Default 310 libinput Tapping Drag Lock Enabled 311 libinput Tapping Drag Lock Enabled Default 312 libinput Tapping Button Mapping Enabled 313 libinput Tapping Button Mapping Default 292 libinput Tapping Enabled 293 libinput Tapping Enabled Default 294 libinput Tapping Drag Enabled 295 libinput Tapping Drag Enabled Default 296 libinput Tapping Drag Lock Enabled 297 libinput Tapping Drag Lock Enabled Default 298 libinput Tapping Button Mapping Enabled 299 libinput Tapping Button Mapping Default Can you also confirm the hardware? Is it by chance a Lenovo Yoga laptop? (In reply to Rajeesh K V from comment #4) > Can you also confirm the hardware? Is it by chance a Lenovo Yoga laptop? It's a Asus ROG G550JK HP Zbook Studio G3 over here. Also experiencing this bug. ** My System ** OS: KDE Neon 5.8.1 64-bit (Plasma Desktop 5.8.1, KDE Frameworks 5.27.0, Qt 5.7.0) PC: HP Pavilion m6-1035dx CPU/GPU: AMD A10-4600M APU with Radeon HD 7660G Graphics (using xorg radeon driver) Linux Kernel: 4.4.0.43-generic Is this issue always reproducible? The problem I experience is when waking from sleep, touchpad is disabled (likely a kernel issue). Other than that, touchpad toggle is working as expected. Run the below command before you press touchpad toggle short cut and report the output: dbus-monitor "type='signal',interface='org.kde.kglobalaccel.Component'" If possible, can you revert commit cf0bf81ccd4c7f8afacda7084978af719340a138 (you may need to revert ca23c39229d607fa45a2d862b44233163853739b first) and check if the issue persists? I pressed the toggle button two times. And it is always reproducible. $ dbus-monitor "type='signal',interface='org.kde.kglobalaccel.Component'" signal time=1477047033.062264 sender=org.freedesktop.DBus -> destination=:1.81 serial=2 path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; member=NameAcquired string ":1.81" signal time=1477047033.062294 sender=org.freedesktop.DBus -> destination=:1.81 serial=4 path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; member=NameLost string ":1.81" signal time=1477047039.599343 sender=:1.13 -> destination=(null destination) serial=1100 path=/component/kcm_touchpad; interface=org.kde.kglobalaccel.Component; member=globalShortcutPressed string "kcm_touchpad" string "Toggle Touchpad" int64 5992314 signal time=1477047041.263323 sender=:1.13 -> destination=(null destination) serial=1101 path=/component/kcm_touchpad; interface=org.kde.kglobalaccel.Component; member=globalShortcutPressed string "kcm_touchpad" string "Toggle Touchpad" int64 5993987 (In reply to Luca Weiss from comment #9) Thanks. > signal time=1477047039.599343 sender=:1.13 -> destination=(null destination) > serial=1100 path=/component/kcm_touchpad; > interface=org.kde.kglobalaccel.Component; member=globalShortcutPressed > string "kcm_touchpad" > string "Toggle Touchpad" > int64 5992314 > signal time=1477047041.263323 sender=:1.13 -> destination=(null destination) > serial=1101 path=/component/kcm_touchpad; > interface=org.kde.kglobalaccel.Component; member=globalShortcutPressed > string "kcm_touchpad" > string "Toggle Touchpad" > int64 5993987 Shortcut triggered twice in succession. Did you press the toggle shortcut twice, or just once? (In reply to Rajeesh K V from comment #10) > (In reply to Luca Weiss from comment #9) > Thanks. > > > signal time=1477047039.599343 sender=:1.13 -> destination=(null destination) > > serial=1100 path=/component/kcm_touchpad; > > interface=org.kde.kglobalaccel.Component; member=globalShortcutPressed > > string "kcm_touchpad" > > string "Toggle Touchpad" > > int64 5992314 > > signal time=1477047041.263323 sender=:1.13 -> destination=(null destination) > > serial=1101 path=/component/kcm_touchpad; > > interface=org.kde.kglobalaccel.Component; member=globalShortcutPressed > > string "kcm_touchpad" > > string "Toggle Touchpad" > > int64 5993987 > > Shortcut triggered twice in succession. Did you press the toggle shortcut > twice, or just once? "I pressed the toggle button two times" Any new information? Same problem on ASUS N56VB i have the same problem on ASUS UX305 (using the default mapping FN-F9) opensuse tumbleweed on 5.8.4. [i have had to map ctrl-F9 to enable touchpad to prevent lockout] same problem on lenovo t420 laptop, kde, always reproducible. touchpad toggle was working properly in fedora23/kde, but stopped in fedora25 (fresh install) My workaround is to have the fn-touchpad toggle call a script which toggles the touchpad. Still annoying, though... Same problem on ASUS K46CB openSUSE Leap 42.2 KDE Plasma 5.8.3 KDE Frameworks 5.26.0 Qt 5.6.1 Kernel 4.4.36-8-default I have the same problem. Touchpad toggle keyboard shortcut is only disabling touchpad. You cannot enable touchpad using this shortcut. I have tried with other key configurations and the result is the same. Hardware: Asus UX303 LN Touchpad: FocalTechPS/2 FocalTech FocalTech Touchpad as /devices/platform/i8042/serio4/input/input5 Kernel: 4.4.36-8-default OS: openSUSE 42.2 KDE Plasma: 5.8.3 KF: 5.26.0 Qt: 5.6.1 ---------- As a workaround you have to assign different keyboard shortcuts for "touchpad enable" and "touchpad disable" actions in systemsettings. Those shortcuts work properly. This also affects me. I did the dbus-monitor experiment, hit the TOGGLE BUTTON twice in succession, and the very same "toggle" even happened but the screen showed the TOUCHPAD OFF display each time and the touchpad was, in fact, turned off. I have Dell XPS 9350 running KDE neon 5.9.3. Same issue here. Using Plasma 5.9.3 on Arch. *** This bug has been confirmed by popular vote. *** I might have identified the issue. propertyChanged() in xlibbackend.cpp doesn't get called (which calls updateCurrentState() in kded.cpp) when the touchpad is disabled but is called when it gets enabled. That leaves a part of the stack to believe that the touchpad is still enabled and tries to set the touchpad to !isEnabled -> disabled. A very quick and dirty fix is adding "m_touchpadEnabled = m_userRequestedState;" to the end of the toggle() method in kded.cpp which lets the kded.cpp believe that the touchpad is disabled even though another part of the stack still believes the touchpad is enabled (that's why it's "dirty"). I honestly think this behavior is bad enough that the responsible thing to do is remove the toggle shortcut altogether -- immediately -- until/unless it's fixed (leaving the separate enable and disable shortcuts in place). *** Bug 381307 has been marked as a duplicate of this bug. *** *** Bug 383145 has been marked as a duplicate of this bug. *** There's a patch working its way through the review process that should fix this: https://phabricator.kde.org/D3829 One day phabricator will stop being stupid and messing up my commits. |