Bug 370398

Summary: trunk/VEX/priv/guest_x86_helpers.c:1693: strange expression ?
Product: [Developer tools] valgrind Reporter: dcb314
Component: generalAssignee: Julian Seward <jseward>
Status: RESOLVED NOT A BUG    
Severity: normal    
Priority: NOR    
Version: 3.12 SVN   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed In:

Description dcb314 2016-10-10 10:01:39 UTC
trunk/VEX/priv/guest_x86_helpers.c:1693:1: warning: V684 A value of the variable 'tagw' is not modified. Consider inspecting the expression. It is possible that '1' should be present instead of '0'.

Source code is

         tagw |= (0 << (2*preg));

Maybe better code

         tagw |= (1 << (2*preg));
Comment 1 Julian Seward 2016-10-17 15:44:44 UTC
The code is as intended.  Compare with line 1688 (a few lines up) and you'll
see why it is written how it is.