| Summary: | ISA 3.0 HW cap stuff needs updating | ||
|---|---|---|---|
| Product: | [Developer tools] valgrind | Reporter: | Carl Love <cel> |
| Component: | vex | Assignee: | Julian Seward <jseward> |
| Status: | CLOSED FIXED | ||
| Severity: | normal | CC: | mark, will_schmidt |
| Priority: | NOR | ||
| Version First Reported In: | 3.12 SVN | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: | hardware cap update | ||
|
Description
Carl Love
2016-10-07 21:53:26 UTC
Created attachment 101480 [details]
hardware cap update
Patch submitted by Will Schmidt. Patch applies cleanly, patch is being tested.
Configure patch committed in Valgrind commit 16034 NEWS file updated in Valgrind commit 16035. Noted the bugzilla listed in commit 16034 was supposed to say bugzilla 370265 not 369175. This updates the min_power_isa check to accept 3.00 instead of 3.0, but the vbit test still uses 3.0 causing test failures in memcheck/tests/vbit-test/vbit-test:
ERROR: invalid ISA version. Valid versions numbers are:
2.05, 2.06, 2.07, 3.00
I tested the following fix on gcc112.fsffrance.org a ppc64le (power8) setup:
diff --git a/memcheck/tests/vbit-test/irops.c b/memcheck/tests/vbit-test/irops.c
index 67e6e47..5b1106a 100644
--- a/memcheck/tests/vbit-test/irops.c
+++ b/memcheck/tests/vbit-test/irops.c
@@ -1287,8 +1287,8 @@ get_irop(IROp op)
case Iop_MulI128by10Carry:
case Iop_MulI128by10E:
case Iop_MulI128by10ECarry: {
- /* IROps require a processor that supports ISA 2.07 (Power 8) or newer */
- rc = system(MIN_POWER_ISA " 3.0 ");
+ /* IROps require a processor that supports ISA 3.00 (Power 9) or newer */
+ rc = system(MIN_POWER_ISA " 3.00 ");
rc /= 256;
/* MIN_POWER_ISA returns 0 if underlying HW supports the
* specified ISA or newer. Returns 1 if the HW does not support
diff --git a/tests/min_power_isa.c b/tests/min_power_isa.c
index e4035ce..37d89f5 100644
--- a/tests/min_power_isa.c
+++ b/tests/min_power_isa.c
@@ -64,7 +64,7 @@ int main(int argc, char **argv)
return !(isa_level >= 8);
} else {
- fprintf(stderr, "ERROR: invalid ISA version. Valid versions numbers are:\n" );
+ fprintf(stderr, "ERROR: invalid ISA version '%s'. Valid versions numbers are:\n", min_isa );
fprintf(stderr, " 2.05, 2.06, 2.07, 3.00\n" );
exit(2);
}
Mark, yup that is a failure. I went back and double checked my regression test runs before I did the commit and I did miss the introduction of the vbit test failure. Note, the nightly regression tests from last night also report the new vbit tester error. I have reopened the bug and am testing your proposed changes. Thanks for catching this. The changes as proposed by Mark above were made. They were tested on Power 7, Power 8 BE and LE. The changes have been committed. Valgrind commit 16037. Mark please take a look at the changes upstream and let me know if it all looks OK to you. Thanks for catching this. (In reply to Carl Love from comment #5) > Valgrind commit 16037. > > Mark please take a look at the changes upstream and let me know if it all > looks OK to you. Thanks for catching this. Looks OK to me and fixes the issue. Thanks. Reclosing as the issue |